[GitHub] [spark] juliuszsompolski commented on pull request #28544: [SPARK-31387][SQL] Handle unknown operation/session ID in HiveThriftServer2Listener

[GitBox <gi...@apache.org>]

juliuszsompolski commented on pull request #28544:
URL: https://github.com/apache/spark/pull/28544#issuecomment-632639380


   > Ur, @juliuszsompolski . In #28544 (comment), did you mean this PR is still failing in some environment?
   
   No, with this PR we didn't see any failures. With the previous PR #28155, we experienced an NPE on these pipeopt filess in some environments specific to Databricks. We added this null checking for pipeout files as an additional safety check there.
   
   It runs for me, and in all testing envs at Databricks.
   ```
   $ git checkout 5198b6853b2e3bc69fc013c653aa163c79168366
   HEAD is now at 5198b6853b2 [SPARK-31387][SQL] Handle unknown operation/session ID in HiveThriftServer2Listener
   $ build/sbt -Phive2.3 -Phadoop2.7 -Phive-thriftserver
   > project hive-thriftserver
   [info] Set current project to spark-hive-thriftserver (in build file:/home/julek/dev/spark3/)
   > test-only *HiveSessionImplSuite
   [info] HiveSessionImplSuite:
   [info] - SPARK-31387 - session.close() closes all sessions regardless of thrown exceptions (2 seconds, 787 milliseconds)
   [info] ScalaTest
   [info] Run completed in 7 seconds, 164 milliseconds.
   [info] Total number of tests run: 1
   [info] Suites: completed 1, aborted 0
   [info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   ```
   
   If the change causes trouble in branch-3.0, let it stay in master only...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org