You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/08 08:36:10 UTC
Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-773
https://issues.apache.org/jira/browse/RANGER-773
Repository: ranger
Description
-------
Patch contains fixes for issues found by coverity scan in Ranger KMS
Diffs
-----
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
Diff: https://reviews.apache.org/r/41080/diff/
Testing
-------
Tested for KMS scenarios related to CRUD operation for key and is working fine.
Thanks,
Gautam Borad
Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/#review109533
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Dec. 9, 2015, 6:03 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41080/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 6:03 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-773
> https://issues.apache.org/jira/browse/RANGER-773
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Patch contains fixes for issues found by coverity scan in Ranger KMS
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
>
> Diff: https://reviews.apache.org/r/41080/diff/
>
>
> Testing
> -------
>
> Tested for KMS scenarios related to CRUD operation for key and is working fine.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 6:03 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Addressing Madhan's comment.
Bugs: RANGER-773
https://issues.apache.org/jira/browse/RANGER-773
Repository: ranger
Description
-------
Patch contains fixes for issues found by coverity scan in Ranger KMS
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
Diff: https://reviews.apache.org/r/41080/diff/
Testing
-------
Tested for KMS scenarios related to CRUD operation for key and is working fine.
Thanks,
Gautam Borad
Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
Posted by dilli dorai <di...@apache.org>.
> On Dec. 8, 2015, 4:12 p.m., Madhan Neethiraj wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java, line 185
> > <https://reviews.apache.org/r/41080/diff/1/?file=1155854#file1155854line185>
> >
> > Please review addKeyEntry() for a similar breakup of synchronized block:
> > synchronized(deltaEntries) {
> > ...
> > deltaEntries.put(alias.toLowerCase(), entry);
> > keyEntries.put(alias.toLowerCase(), entry);
> > }
What were the issues reported by coverity?
Without knowing that, how does one review the code?
- dilli
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/#review109336
-----------------------------------------------------------
On Dec. 8, 2015, 7:36 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41080/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:36 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-773
> https://issues.apache.org/jira/browse/RANGER-773
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Patch contains fixes for issues found by coverity scan in Ranger KMS
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
>
> Diff: https://reviews.apache.org/r/41080/diff/
>
>
> Testing
> -------
>
> Tested for KMS scenarios related to CRUD operation for key and is working fine.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
Posted by dilli dorai <di...@apache.org>.
> On Dec. 8, 2015, 4:12 p.m., Madhan Neethiraj wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java, line 185
> > <https://reviews.apache.org/r/41080/diff/1/?file=1155854#file1155854line185>
> >
> > Please review addKeyEntry() for a similar breakup of synchronized block:
> > synchronized(deltaEntries) {
> > ...
> > deltaEntries.put(alias.toLowerCase(), entry);
> > keyEntries.put(alias.toLowerCase(), entry);
> > }
>
> dilli dorai wrote:
> What were the issues reported by coverity?
> Without knowing that, how does one review the code?
You could ignore the comment, JIRAS has some details
- dilli
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/#review109336
-----------------------------------------------------------
On Dec. 8, 2015, 7:36 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41080/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:36 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-773
> https://issues.apache.org/jira/browse/RANGER-773
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Patch contains fixes for issues found by coverity scan in Ranger KMS
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
>
> Diff: https://reviews.apache.org/r/41080/diff/
>
>
> Testing
> -------
>
> Tested for KMS scenarios related to CRUD operation for key and is working fine.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41080: RANGER-773 : Fix newly found Coverity scan
issues for Ranger KMS
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41080/#review109336
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java (line 185)
<https://reviews.apache.org/r/41080/#comment168815>
Please review addKeyEntry() for a similar breakup of synchronized block:
synchronized(deltaEntries) {
...
deltaEntries.put(alias.toLowerCase(), entry);
keyEntries.put(alias.toLowerCase(), entry);
}
- Madhan Neethiraj
On Dec. 8, 2015, 7:36 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41080/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:36 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-773
> https://issues.apache.org/jira/browse/RANGER-773
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Patch contains fixes for issues found by coverity scan in Ranger KMS
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f
>
> Diff: https://reviews.apache.org/r/41080/diff/
>
>
> Testing
> -------
>
> Tested for KMS scenarios related to CRUD operation for key and is working fine.
>
>
> Thanks,
>
> Gautam Borad
>
>