[GitHub] [solr] magibney commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

[GitBox <gi...@apache.org>]

magibney commented on pull request #592:
URL: https://github.com/apache/solr/pull/592#issuecomment-1083391036


   I'm hoping to commit this this week.
   
   I did want first to specifically call out that _after_ @dsmiley's PR approval, there were changes to the way the liveDocs DocSet is cached: basically, no longer uses a 1-element CaffeineCache and instead handles synchronization manually within SIS, adding a few metrics mainly to support test assertions. I'm comfortable with this approach and pretty sure the concurrency stuff is correct and idiomatic, but in case anyone wants to take another look before I commit, the substance of the new approach is mostly at [SIS.populateLiveDocs](https://github.com/apache/solr/blob/91222454725122a76399348eb3143e373d2b222c/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1007-L1035).
   
   Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org