You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/06/02 14:17:58 UTC
[GitHub] flink pull request #2065: [FLINK-4011] Keep UserCodeClassLoader in archived ...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2065
[FLINK-4011] Keep UserCodeClassLoader in archived ExecutionGraphs
Currently, completed jobs cannot be accessed in the web frontend, because the classloader passed to `SerializedValue` is always null.
There are different approaches to resolve this issue:
- Use the system classloader to deserialize the EC. This means that as soon as the EC contains user code, we can not deserialize it. The web frontent will show fewer information
- In `ExecutionGraph.prepareForArchiving()`, we deserialize the EC into a special field, then we set the user code classloader free for GCing. This would be a hacky approach because we would have two ECs (serialized, regular instance) in the EG.
- Keep the usercodeclassloader in the EC. This means the classes of the job can not be unloaded from the JobManager JVM until the job has been removed from the JM history.
I'm open for discussing more approaches or alternative solutions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink4011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2065
----
commit 388e75c95cd4e63419af429102e8afcfcd11cb8f
Author: Robert Metzger <rm...@apache.org>
Date: 2016-06-02T14:08:07Z
[FLINK-4011] Keep UserCodeClassLoader in archived ExecutionGraphs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2065: [FLINK-4011] Keep UserCodeClassLoader in archived Executi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2065
Given the current status, this is a good pragmatic fif.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2065: [FLINK-4011] Keep UserCodeClassLoader in archived Executi...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2065
Thank you for the review. I'll merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2065: [FLINK-4011] Keep UserCodeClassLoader in archived Executi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2065
You already outlined one of the drawbacks (holding on to the classes).
There are probably other parts in the execution graph that currently hold onto user defined classes as well.
A good (but more involved) longer term solution would be to create a "archived execution graph" that can be serialized and that does not contain any user classes, but only "stringified" versions of configs, accumulators, metrics, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2065: [FLINK-4011] Keep UserCodeClassLoader in archived ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2065
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---