You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/22 16:28:49 UTC

[GitHub] [geode-native] mmartell commented on a change in pull request #615: GEODE-8231: remove bucket server location from metadata when server down

mmartell commented on a change in pull request #615:
URL: https://github.com/apache/geode-native/pull/615#discussion_r443683084



##########
File path: cppcache/integration/test/CMakeLists.txt
##########
@@ -27,6 +27,7 @@ add_executable(cpp-integration-test
   ExampleTest.cpp
   ExpirationTest.cpp
   FunctionExecutionTest.cpp
+  PartitionRegionOpsWithRedundancyAndServerGoesDown.cpp

Review comment:
       I tend to always work in an IDE that supports project view (Visual Studio, Xcode), wherein I already know I'm working with a test project. Hence the Test suffix is a bit redundant. Also, we already have 4 tests in the new framework that don't use the Test suffix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org