You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/02/06 00:39:20 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1247: Automatically build and push the docker image when tagging a new version
git-hulk opened a new pull request, #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247
This closes #1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247#discussion_r1096906542
##########
.github/workflows/release.yaml:
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: release docker image
+
+on:
+ push:
+ tags:
+ - v*
+
+jobs:
+ release-docker-image:
+ name: Release Docker Image
+ runs-on: ubuntu-18.04
+ steps:
+
+ - name: Checkout Code Base
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 64
+
+ - name: Set ENV
+ run: |
+ echo "RELEASE_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
Review Comment:
We can remove the `v` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247#issuecomment-1418481294
Thanks all, merging...
@caipengbo Can help to push a new tag to have a try, the DOCKER_USERNAME and DOCKER_PASSWORD had existed before if my memory serves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247#issuecomment-1418517998
This is already discussed at:
* https://github.com/apache/incubator-kvrocks/pull/588#issuecomment-1131320266
* https://github.com/apache/incubator-kvrocks/pull/752#issuecomment-1194936068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247#discussion_r1096906411
##########
.github/workflows/release.yaml:
##########
@@ -0,0 +1,58 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: release docker image
+
+on:
+ push:
+ tags:
+ - v*
+
+jobs:
+ release-docker-image:
+ name: Release Docker Image
+ runs-on: ubuntu-18.04
+ steps:
+
+ - name: Checkout Code Base
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 64
+
+ - name: Set ENV
+ run: |
+ echo "RELEASE_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
Review Comment:
```suggestion
echo "RELEASE_TAG=${GITHUB_REF#refs/*/v}" >> $GITHUB_ENV
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1247: Automatically build and push the docker image when tagging a new version
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1247:
URL: https://github.com/apache/incubator-kvrocks/pull/1247#issuecomment-1418544446
OK, let's reverse this change and do them manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org