You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/05 14:06:41 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4030: some minor changes to make the build run with python 3

GabrielBrascher commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r465751633



##########
File path: tools/apidoc/gen_toc.py
##########
@@ -245,10 +245,10 @@ def choose_category(fn):
 
 def xml_for(command):
     name = command['name']
-    async = command['async'] and ' (A)' or ''
+    asyncmethod = command['async'] and ' (A)' or ''

Review comment:
       @DaanHoogland shouldn't the header of this python file be changed from `#!/cygdrive/c/Python27` to `#!/cygdrive/c/Python3`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org