You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2017/08/04 15:49:30 UTC
Review Request 61427: Make sure the original ClassLoader is restored
when running HCatalog tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61427/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3218
https://issues.apache.org/jira/browse/SQOOP-3218
Repository: sqoop-trunk
Description
-------
Make sure the original ClassLoader is restored when running HCatalog tests
Diffs
-----
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 2101b0687bb2307edfa5dc6e6eb1a20eb462f981
src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatUtilities.java PRE-CREATION
Diff: https://reviews.apache.org/r/61427/diff/1/
Testing
-------
Unit tests and third party tests were ran.
Thanks,
Szabolcs Vasas
Re: Review Request 61427: Make sure the original ClassLoader is
restored when running HCatalog tests
Posted by Zoltán Tóth <sw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61427/#review182692
-----------------------------------------------------------
Ship it!
Applied and tested
- Zoltán Tóth
On Aug. 4, 2017, 3:49 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61427/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2017, 3:49 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3218
> https://issues.apache.org/jira/browse/SQOOP-3218
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Make sure the original ClassLoader is restored when running HCatalog tests
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 2101b0687bb2307edfa5dc6e6eb1a20eb462f981
> src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatUtilities.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61427/diff/1/
>
>
> Testing
> -------
>
> Unit tests and third party tests were ran.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 61427: Make sure the original ClassLoader is
restored when running HCatalog tests
Posted by Boglarka Egyed <eg...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61427/#review182703
-----------------------------------------------------------
Ship it!
Hi Szabi,
Your change looks good, thanks for this fix!
I ran unit and 3rd party tests successfully with your patch.
Cheers,
Bogi
- Boglarka Egyed
On Aug. 4, 2017, 3:49 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61427/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2017, 3:49 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3218
> https://issues.apache.org/jira/browse/SQOOP-3218
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Make sure the original ClassLoader is restored when running HCatalog tests
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 2101b0687bb2307edfa5dc6e6eb1a20eb462f981
> src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatUtilities.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61427/diff/1/
>
>
> Testing
> -------
>
> Unit tests and third party tests were ran.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>