You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/07 08:26:51 UTC

[GitHub] [skywalking-rust] dkkb opened a new pull request #7: Add GitHub action for test.

dkkb opened a new pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7


   This workflow is inspired by one of my personal projects `dakv`. 
   
   https://github.com/dakv/dakv/blob/master/.github/workflows/test.yml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] wu-sheng commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007229346


   Ping @Shikugawa for confirmation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] dkkb commented on a change in pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
dkkb commented on a change in pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#discussion_r780101521



##########
File path: .github/workflows/test.yaml
##########
@@ -0,0 +1,16 @@
+on: [push, pull_request]

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] wu-sheng commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225583






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] wu-sheng commented on a change in pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#discussion_r780098146



##########
File path: .github/workflows/test.yaml
##########
@@ -0,0 +1,16 @@
+on: [push, pull_request]

Review comment:
       `push` should only be for the master branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] codecov-commenter edited a comment on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225871


   # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@bb13864`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-rust/pull/7/graphs/tree.svg?width=650&height=150&src=pr&token=F7BQW5GURE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master       #7   +/-   ##
   =========================================
     Coverage          ?   88.60%           
   =========================================
     Files             ?        9           
     Lines             ?      272           
     Branches          ?        0           
   =========================================
     Hits              ?      241           
     Misses            ?       31           
     Partials          ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bb13864...e6b7cd6](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] codecov-commenter commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225871


   # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@bb13864`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-rust/pull/7/graphs/tree.svg?width=650&height=150&src=pr&token=F7BQW5GURE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master       #7   +/-   ##
   =========================================
     Coverage          ?   88.60%           
   =========================================
     Files             ?        9           
     Lines             ?      272           
     Branches          ?        0           
   =========================================
     Hits              ?      241           
     Misses            ?       31           
     Partials          ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bb13864...f541996](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] dkkb commented on a change in pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
dkkb commented on a change in pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#discussion_r780101521



##########
File path: .github/workflows/test.yaml
##########
@@ -0,0 +1,16 @@
+on: [push, pull_request]

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] codecov-commenter edited a comment on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225871


   # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@bb13864`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-rust/pull/7/graphs/tree.svg?width=650&height=150&src=pr&token=F7BQW5GURE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master       #7   +/-   ##
   =========================================
     Coverage          ?   88.60%           
   =========================================
     Files             ?        9           
     Lines             ?      272           
     Branches          ?        0           
   =========================================
     Hits              ?      241           
     Misses            ?       31           
     Partials          ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bb13864...e6b7cd6](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] wu-sheng commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225583


   What is this actually testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] dkkb commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
dkkb commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007228994


   > What is this actually testing?
   
   It can be used to run tests (include examples in documentation) with coverage and upload the code coverage reports to codecov.
   
   
   ![image](https://user-images.githubusercontent.com/82504881/148515561-157c5ba4-f959-4767-b1cd-040dc816e069.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] Shikugawa merged pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
Shikugawa merged pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] dkkb commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
dkkb commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007228994


   > What is this actually testing?
   
   It can be used to run tests (include examples in documentation) with coverage and upload the code coverage reports to codecov.
   
   
   ![image](https://user-images.githubusercontent.com/82504881/148515561-157c5ba4-f959-4767-b1cd-040dc816e069.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] wu-sheng commented on a change in pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#discussion_r780098146



##########
File path: .github/workflows/test.yaml
##########
@@ -0,0 +1,16 @@
+on: [push, pull_request]

Review comment:
       `push` should only be for the master branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] Shikugawa merged pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
Shikugawa merged pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rust] codecov-commenter commented on pull request #7: Add GitHub action for test.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7:
URL: https://github.com/apache/skywalking-rust/pull/7#issuecomment-1007225871


   # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@bb13864`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-rust/pull/7/graphs/tree.svg?width=650&height=150&src=pr&token=F7BQW5GURE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master       #7   +/-   ##
   =========================================
     Coverage          ?   88.60%           
   =========================================
     Files             ?        9           
     Lines             ?      272           
     Branches          ?        0           
   =========================================
     Hits              ?      241           
     Misses            ?       31           
     Partials          ?        0           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bb13864...f541996](https://codecov.io/gh/apache/skywalking-rust/pull/7?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org