[GitHub] [incubator-superset] etr2460 opened a new pull request #7993: [Jinja] Make Presto template functions backwards compatible

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #7993: [Jinja] Make Presto template functions backwards compatible
URL: https://github.com/apache/incubator-superset/pull/7993
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   https://github.com/apache/incubator-superset/pull/7782 changed the behavior of the `presto.latest_partition` Jinja template function to return an array instead of a string, breaking all sql metrics/slices that used it. This PR makes the `latest_partition` function behave the same as prior to this change, introduces a new function `presto.latest_partitions` that can be used with this new behavior, and provides documentation for the change in code.
   
   It might be worth renaming these functions if we were ever to do a breaking release of superset, but i don't see that happening any time soon.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Tested locally, CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @michellethomas @john-bodley @betodealmeida @DiggidyDave @xtinec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org