You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/05/20 17:39:18 UTC

[GitHub] [knox] moresandeep commented on a diff in pull request #579: KNOX-2726 - Impersonation Params should be configurable

moresandeep commented on code in PR #579:
URL: https://github.com/apache/knox/pull/579#discussion_r878391153


##########
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##########
@@ -55,9 +56,16 @@ public class CommonIdentityAssertionFilter extends AbstractIdentityAssertionFilt
 
   public static final String GROUP_PRINCIPAL_MAPPING = "group.principal.mapping";
   public static final String PRINCIPAL_MAPPING = "principal.mapping";
+  /* Service specific impersonation params that needs to be scrubbed */
+  public static final String IMPERSONATION_PARAMS = "impersonation.params";

Review Comment:
   @zeroflag which constant are you referring to? or are you suggesting moving this to `AbstractIdentityAssertionFilter`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org