You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by sanjaypujare <gi...@git.apache.org> on 2016/06/30 01:20:09 UTC
[GitHub] apex-malhar pull request #329: Fix for APEXMALHAR-2069: moved creation of sc...
GitHub user sanjaypujare opened a pull request:
https://github.com/apache/apex-malhar/pull/329
Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vro\u2026
@vrozov pls review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaypujare/apex-malhar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit beb394bbd5d136ccc49ed9ac4da060066ad59252
Author: Sanjay Pujare <sa...@sanjay-dt-macbook-pro.local>
Date: 2016-06-30T01:08:30Z
Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vrozov pls review
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #329: APEXMALHAR-2069: moved creation of scanServic...
Posted by sanjaypujare <gi...@git.apache.org>.
Github user sanjaypujare closed the pull request at:
https://github.com/apache/apex-malhar/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #329: Fix for APEXMALHAR-2069: moved creation of sc...
Posted by sanjaypujare <gi...@git.apache.org>.
GitHub user sanjaypujare reopened a pull request:
https://github.com/apache/apex-malhar/pull/329
Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vro\u2026
@vrozov pls review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanjaypujare/apex-malhar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit beb394bbd5d136ccc49ed9ac4da060066ad59252
Author: Sanjay Pujare <sa...@sanjay-dt-macbook-pro.local>
Date: 2016-06-30T01:08:30Z
Fix for APEXMALHAR-2069: moved creation of scanService to setup, @vrozov pls review
commit 919fdfca2886a45c42e747283ee75d7243c5c3ff
Author: Sanjay Pujare <sa...@sanjay-dt-macbook-pro.local>
Date: 2016-07-01T01:05:07Z
Fix for APEXMALHAR-2069: throw a RuntimeException if scanService is already set, fix unit tests to call setup only on WindowDataManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #329: Fix for APEXMALHAR-2069: moved creation of sc...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-malhar/pull/329#discussion_r69063970
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -318,6 +317,9 @@ public TimeBasedDirectoryScanner()
@Override
public void setup(Context.OperatorContext context)
{
+ if (scanService == null) {
--- End diff --
why is it necessary to check for null? Under what condition it will be not null? As far as I know platform calls setup/terminate once per deployment. IMO, it is safer to create new execution service each time setup is called and possibly assert or throw RuntimeException if scanService is not null to avoid misusage in unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-malhar pull request #329: Fix for APEXMALHAR-2069: moved creation of sc...
Posted by sanjaypujare <gi...@git.apache.org>.
Github user sanjaypujare closed the pull request at:
https://github.com/apache/apex-malhar/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---