You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2019/06/08 20:31:53 UTC

[maven-resolver] branch MRESOLVER-9 created (now 11baaf5)

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a change to branch MRESOLVER-9
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git.


      at 11baaf5  [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

This branch includes the following new commits:

     new 11baaf5  [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[maven-resolver] 01/01: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch MRESOLVER-9
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git

commit 11baaf5d9a83ecc948f56fdc232d2855cc3875e3
Author: Christian Schulte <cs...@schulte.it>
AuthorDate: Sat Mar 11 22:39:20 2017 +0100

    [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.
---
 .../internal/impl/collect/DefaultDependencyCollector.java      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
index 9d37435..98db0dc 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
@@ -433,16 +433,16 @@ public class DefaultDependencyCollector
         Args args = context.getArgs();
         Results results = context.getResults();
 
-        if ( context.getDepSelector() != null && !context.getDepSelector().selectDependency( dc.origDependency ) )
-        {
-            return null;
-        }
-
         PremanagedDependency preManaged =
                 PremanagedDependency.create( context.getDepManager(), dc.origDependency, dc.disableVersionManagement,
                                              args.premanagedState );
         Dependency dependency = preManaged.managedDependency;
 
+        if ( context.getDepSelector() != null && !context.getDepSelector().selectDependency( dc.origDependency ) )
+        {
+            return null;
+        }
+
         boolean noDescriptor = isLackingDescriptor( dependency.getArtifact() );
 
         boolean traverse = !noDescriptor