You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tomasz Pik (JIRA)" <ji...@codehaus.org> on 2007/10/07 21:53:08 UTC
[jira] Created: (MWAR-123) filtering with @ is working randomly
filtering with @ is working randomly
------------------------------------
Key: MWAR-123
URL: http://jira.codehaus.org/browse/MWAR-123
Project: Maven 2.x War Plugin
Issue Type: Bug
Affects Versions: 2.1-alpha-1
Reporter: Tomasz Pik
Attachments: filters.patch
Attached patch adding testing for filtering using @...@ (in parallel with filtering using ${..}) tokens.
However, if you'll change
# this is comment created by author at somewhere
to
# this is comment created by author@somewhere"
then test case will fall.
As far as I know this problem has a root in plexus utils but this is very important for filtering jsp files (and so - for maven-war-plugin) because @ character has a special meaning in jsp.
So adding a directive like <%@ page import="package" %> will effectively 'disable' filtering.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-123) filtering with @ is working randomly
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MWAR-123.
-----------------------------
Assignee: Olivier Lamy
Resolution: Fixed
Fix Version/s: 2.1-alpha-1
committed in rev 584872.
Thanks.
> filtering with @ is working randomly
> ------------------------------------
>
> Key: MWAR-123
> URL: http://jira.codehaus.org/browse/MWAR-123
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Affects Versions: 2.1-alpha-1
> Reporter: Tomasz Pik
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-1
>
> Attachments: filters.patch
>
>
> Attached patch adding testing for filtering using @...@ (in parallel with filtering using ${..}) tokens.
> However, if you'll change
> # this is comment created by author at somewhere
> to
> # this is comment created by author@somewhere"
> then test case will fall.
> As far as I know this problem has a root in plexus utils but this is very important for filtering jsp files (and so - for maven-war-plugin) because @ character has a special meaning in jsp.
> So adding a directive like <%@ page import="package" %> will effectively 'disable' filtering.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira