You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2017/09/17 12:30:02 UTC

[myfaces-trinidad] 21/30: Checkpoint: one more minor code cleanup task: marked a couple of instance variables as final.

This is an automated email from the ASF dual-hosted git repository.

deki pushed a commit to branch andys-skin-pregen
in repository https://gitbox.apache.org/repos/asf/myfaces-trinidad.git

commit 2f1b0cd3874f0c704f71556d322f27db848a2d70
Author: Andy Schwartz <an...@apache.org>
AuthorDate: Fri Mar 16 14:08:54 2012 +0000

    Checkpoint: one more minor code cleanup task: marked a couple of instance variables as final.
---
 .../myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java   | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java
index d2ea321..5e44437 100644
--- a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java
+++ b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java
@@ -713,13 +713,18 @@ public final class AgentAtRuleMatcher
       // their hash codes each time our hash code is called
       _hashCode = matchers.hashCode();
 
+      boolean hasVersionMatcher = false;
+      boolean hasTouchMatcher = false;
       for (AgentMatcher matcher : matchers)
       {
         if (matcher instanceof VersionMatcher)
-          _hasVersionMatcher = true;
+          hasVersionMatcher = true;
         if (matcher instanceof TouchScreenCapabilityMatcher)
-          _hasTouchScreenCapabilityMatcher = true;
+          hasTouchMatcher = true;
       }
+      
+      _hasVersionMatcher = hasVersionMatcher;
+      _hasTouchScreenCapabilityMatcher = hasTouchMatcher;
     }
 
     protected boolean hasTouchScreenCapabilityMatcher()
@@ -800,8 +805,8 @@ public final class AgentAtRuleMatcher
 
     private final List<AgentMatcher> _matchers;
     private final int _hashCode;
-    private boolean _hasVersionMatcher;
-    private boolean _hasTouchScreenCapabilityMatcher;
+    private final boolean _hasVersionMatcher;
+    private final boolean _hasTouchScreenCapabilityMatcher;
   }
 
   /**

-- 
To stop receiving notification emails like this one, please contact
"commits@myfaces.apache.org" <co...@myfaces.apache.org>.