You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Gary Tully (JIRA)" <ji...@apache.org> on 2011/09/14 10:30:09 UTC

[jira] [Created] (AMQ-3496) Provide configurable default for unqualified stomp reply-to header destination string

Provide configurable default for unqualified stomp reply-to header destination string
-------------------------------------------------------------------------------------

                 Key: AMQ-3496
                 URL: https://issues.apache.org/jira/browse/AMQ-3496
             Project: ActiveMQ
          Issue Type: Improvement
          Components: Transport
    Affects Versions: 5.6.0
            Reporter: Gary Tully
            Assignee: Gary Tully
            Priority: Minor
             Fix For: 5.6.0


Sending a STOMP message with a test string ("some destination") as the "reply-to" header and ActiveMQ rejected it:
Illegal destination name: [some destination] -- ActiveMQ STOMP destinations must begin with one of: /queue/ /topic/ /temp-queue/ /temp-topic/
The JMS specification contains:{quote}
The JMSReplyTo header field contains a Destination supplied by a client when
a message is sent. It is the destination where a reply to the message should be
sent. [...]
Messages sent with a JMSReplyTo value are typically expecting a response. A
response may be optional, it is up to the client to decide.{quote}

Because stomp is layered over jms, we need to default the destination type of any arbitrary string such that the intent is encoded in the destination name.

Making use of the org.apache.activemq.command.UnresolvedDestinationTransformer from https://issues.apache.org/jira/browse/AMQ-3401 makes sense in this case.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AMQ-3496) Provide configurable default for unqualified stomp reply-to header destination string

Posted by "Dejan Bosanac (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173082#comment-13173082 ] 

Dejan Bosanac commented on AMQ-3496:
------------------------------------

In svn revision 1221199 I added some more logic around handling reply-to. It basically tries to convert String to destination and if it succeeds it will set JMSReplyTo header. If conversion fails, it will just set simple String reply-to header. In this manner we can support using non-JMS reply-to values over Stomp. I left usage of UnresolvedDestinationTransformer for all other destination conversions.
                
> Provide configurable default for unqualified stomp reply-to header destination string
> -------------------------------------------------------------------------------------
>
>                 Key: AMQ-3496
>                 URL: https://issues.apache.org/jira/browse/AMQ-3496
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Transport
>    Affects Versions: 5.x
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Minor
>             Fix For: 5.6.0
>
>
> Sending a STOMP message with a test string ("some destination") as the "reply-to" header and ActiveMQ rejected it:
> Illegal destination name: [some destination] -- ActiveMQ STOMP destinations must begin with one of: /queue/ /topic/ /temp-queue/ /temp-topic/
> The JMS specification contains:{quote}
> The JMSReplyTo header field contains a Destination supplied by a client when
> a message is sent. It is the destination where a reply to the message should be
> sent. [...]
> Messages sent with a JMSReplyTo value are typically expecting a response. A
> response may be optional, it is up to the client to decide.{quote}
> Because stomp is layered over jms, we need to default the destination type of any arbitrary string such that the intent is encoded in the destination name.
> Making use of the org.apache.activemq.command.UnresolvedDestinationTransformer from https://issues.apache.org/jira/browse/AMQ-3401 makes sense in this case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AMQ-3496) Provide configurable default for unqualified stomp reply-to header destination string

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-3496.
-----------------------------

    Resolution: Fixed

resolved in http://svn.apache.org/viewvc?rev=1170474&view=rev

reuse of org.apache.activemq.command.UnresolvedDestinationTransformer

> Provide configurable default for unqualified stomp reply-to header destination string
> -------------------------------------------------------------------------------------
>
>                 Key: AMQ-3496
>                 URL: https://issues.apache.org/jira/browse/AMQ-3496
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Transport
>    Affects Versions: 5.6.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Minor
>             Fix For: 5.6.0
>
>
> Sending a STOMP message with a test string ("some destination") as the "reply-to" header and ActiveMQ rejected it:
> Illegal destination name: [some destination] -- ActiveMQ STOMP destinations must begin with one of: /queue/ /topic/ /temp-queue/ /temp-topic/
> The JMS specification contains:{quote}
> The JMSReplyTo header field contains a Destination supplied by a client when
> a message is sent. It is the destination where a reply to the message should be
> sent. [...]
> Messages sent with a JMSReplyTo value are typically expecting a response. A
> response may be optional, it is up to the client to decide.{quote}
> Because stomp is layered over jms, we need to default the destination type of any arbitrary string such that the intent is encoded in the destination name.
> Making use of the org.apache.activemq.command.UnresolvedDestinationTransformer from https://issues.apache.org/jira/browse/AMQ-3401 makes sense in this case.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira