[GitHub] [airflow] dstandish commented on a diff in pull request #26945: Add nodePort declaration to chart/values.schema.json

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #26945:
URL: https://github.com/apache/airflow/pull/26945#discussion_r991652606


##########
tests/charts/test_webserver.py:
##########
@@ -721,6 +721,30 @@ def test_should_add_component_specific_labels(self):
         assert "test_label" in jmespath.search("metadata.labels", docs[0])
         assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
 
+    @parameterized.expand(
+        [
+            (
+                [{"name": "webserver-nodeport", "nodePort": "31000", "port": "8080"}],
+                [{"name": "webserver-nodeport", "nodePort": 31000, "port": 8080}],
+            )
+        ]
+    )
+    def test_nodeport_service(self, ports, expected_ports):

Review Comment:
   looks like your params aren't consistent with those provided in expand
   but let's see what the tests tell us
   i'd also add an entry (in  expand) for when no port is provided
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org