[GitHub] [iotdb] SiasDoming commented on pull request #3382: fix iotdb-env.bat not working

[GitBox <gi...@apache.org>]

SiasDoming commented on pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382#issuecomment-858366457


   > Hi, thanks so much for your contribution!
   > 
   > I find out there are some lines about `SetEnvironmentVariable` in Windows CI workflow. Is it the reason why the Windows tests failed?
   > 
   > https://github.com/apache/iotdb/blob/fe983ed81b97aa8b232bbdde57df08f5e9c32b0d/.github/workflows/main-win.yml#L85-L88
   
   I'm not familiar with CI workflows, but it seems these lines are working with the Hadoop environment and I prefer that these have nothing to do with my modifications. All I've done is within the cope of iotdb-env.bat, which means even if the SETLOCAL clause is deleted, all variables are only valid in the lifecycle of the single command line. 
   By the way, although iotdb-env.bat may modify environment variables within the command line, thus causing errors when some variables with the same names are vital for other commands or scripts, it's mostly called by start-server.bat and the latter has a SETLOCAL clause before calling it and this will strict all variables to be valid within the start-server.bat.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org