[GitHub] [spark] beliefer commented on a change in pull request #24267: [MINOR][Streaming][Kafka]Arrange scattered config for kafka 10.

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #24267: [MINOR][Streaming][Kafka]Arrange scattered config for kafka 10.
URL: https://github.com/apache/spark/pull/24267#discussion_r271552851
 
 

 ##########
 File path: external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/KafkaRDD.scala
 ##########
 @@ -64,16 +64,12 @@ private[spark] class KafkaRDD[K, V](
       " must be set to false for executor kafka params, else offsets may commit before processing")
 
   // TODO is it necessary to have separate configs for initial poll time vs ongoing poll time?
-  private val pollTimeout = conf.getLong("spark.streaming.kafka.consumer.poll.ms",
+  private val pollTimeout = conf.get(CONSUMER_POLL_MS).getOrElse(
     conf.getTimeAsSeconds("spark.network.timeout", "120s") * 1000L)
 
 Review comment:
   > Can we use the existing config in core for this?
   
   What do you mean by replacing `spark.network.timeout` with existing config in core?  I checked the code in core have config `spark.network.timeout` not yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org