[GitHub] [rocketmq-docker] vongosling commented on a change in pull request #8: [Fix issue #7] Add pre-prepared data dir to avoid auto-created directories with root permission

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #8: [Fix issue #7] Add pre-prepared data dir to avoid auto-created directories with root permission
URL: https://github.com/apache/rocketmq-docker/pull/8#discussion_r317346714
 
 

 ##########
 File path: templates/play-docker-deledger.sh
 ##########
 @@ -31,22 +31,33 @@ if [[ -n "$DLEDGER_NET" ]]; then
    sleep 5
 fi
 
-if [ ! -d "`pwd`/data" ]; then
-  mkdir -p "data"
-fi
+prepare_dir()
+{
+    dirs=("data/namesrv/logs" "data/broker0/logs" "data/broker0/store" "data/broker1/logs" "data/broker1/store" "data/broker2/logs" "data/broker2/store")
 
 Review comment:
   why did you only remove the volumeMounts - ./data/namesrv/store:/home/rocketmq/store but leave all volume locations in here?	

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services