You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/03 18:40:15 UTC

[GitHub] Fokko commented on a change in pull request #3838: [AIRFLOW-2997] Support for Bigquery clustered tables

Fokko commented on a change in pull request #3838: [AIRFLOW-2997] Support for Bigquery clustered tables
URL: https://github.com/apache/incubator-airflow/pull/3838#discussion_r214744783
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -943,6 +962,14 @@ def run_load(self,
                 'timePartitioning': time_partitioning
             })
 
+        if cluster_fields:
 
 Review comment:
   Maybe separate this logic to a separate function? Since it is defined twice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services