You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/08/16 04:57:26 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo

michaelandrepearce commented on a change in pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo
URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314583108
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ##########
 @@ -484,7 +482,7 @@ public QueueBinding updateQueue(SimpleString name,
                                    Long delayBeforeDispatch,
                                    SimpleString user,
                                    Boolean configurationManaged) throws Exception {
-      synchronized (addressLock) {
+      synchronized (this) {
 
 Review comment:
   Why not make synchronized method for these methods if the whole block is syncd? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services