You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2018/12/02 07:06:27 UTC
[kudu-CR] [docs] Fix error gflags
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12023
Change subject: [docs] Fix error gflags
......................................................................
[docs] Fix error gflags
Change-Id: Id7d846fbacdd294b13139cfc17dba095aae7aa3e
---
M docs/security.adoc
1 file changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/12023/1
--
To view, visit http://gerrit.cloudera.org:8080/12023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7d846fbacdd294b13139cfc17dba095aae7aa3e
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [docs] Fix error gflags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12023 )
Change subject: [docs] Fix error gflags
......................................................................
[docs] Fix error gflags
Change-Id: Id7d846fbacdd294b13139cfc17dba095aae7aa3e
Reviewed-on: http://gerrit.cloudera.org:8080/12023
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/security.adoc
1 file changed, 15 insertions(+), 15 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7d846fbacdd294b13139cfc17dba095aae7aa3e
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [docs] Fix error gflags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12023 )
Change subject: [docs] Fix error gflags
......................................................................
Patch Set 1: Code-Review+2
FWIW, it's OK to use --foo-bar or --foo_bar for gflag key names. But I agree that it's better to consistently use the same form in documentation, and I think we've implicitly chosen --foo_bar there.
--
To view, visit http://gerrit.cloudera.org:8080/12023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7d846fbacdd294b13139cfc17dba095aae7aa3e
Gerrit-Change-Number: 12023
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 18:57:57 +0000
Gerrit-HasComments: No