You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2016/01/04 15:47:03 UTC

Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41885/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1714
    https://issues.apache.org/jira/browse/FALCON-1714


Repository: falcon-git


Description
-------

EntityNotRegisteredException when process with no input/output feed is scheduled


Diffs
-----

  prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java bb3b8e0 

Diff: https://reviews.apache.org/r/41885/diff/


Testing
-------


Thanks,

Ajay Yadava


Re: Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41885/#review112629
-----------------------------------------------------------

Ship it!


Ship It!

- Sowmya Ramesh


On Jan. 4, 2016, 2:47 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41885/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 2:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1714
>     https://issues.apache.org/jira/browse/FALCON-1714
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> EntityNotRegisteredException when process with no input/output feed is scheduled
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java bb3b8e0 
> 
> Diff: https://reviews.apache.org/r/41885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

Posted by Ajay Yadava <aj...@gmail.com>.

> On Jan. 4, 2016, 3:46 p.m., Peeyush Bishnoi wrote:
> > prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java, line 57
> > <https://reviews.apache.org/r/41885/diff/1/?file=1180907#file1180907line57>
> >
> >     Should not be here check for "IGNORE" as well along with check for "NONE".

We don't put IGNORE for output feed names, we put only "NONE". There are some places where we put IGNORE and some places where we put "NONE" hence it is confusing. But for this particular case it is "NONE". You can see the same in the stack trace of the error in the description and also in the OozieProcessWorkflowBuilderTest#testProcessWithInputsNoOutputs.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41885/#review112585
-----------------------------------------------------------


On Jan. 4, 2016, 2:47 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41885/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 2:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1714
>     https://issues.apache.org/jira/browse/FALCON-1714
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> EntityNotRegisteredException when process with no input/output feed is scheduled
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java bb3b8e0 
> 
> Diff: https://reviews.apache.org/r/41885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41885/#review112585
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java (line 57)
<https://reviews.apache.org/r/41885/#comment173085>

    Should not be here check for "IGNORE" as well along with check for "NONE".


- Peeyush Bishnoi


On Jan. 4, 2016, 2:47 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41885/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 2:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1714
>     https://issues.apache.org/jira/browse/FALCON-1714
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> EntityNotRegisteredException when process with no input/output feed is scheduled
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java bb3b8e0 
> 
> Diff: https://reviews.apache.org/r/41885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41885/#review112644
-----------------------------------------------------------

Ship it!


Ship It!

- Balu Vellanki


On Jan. 4, 2016, 2:47 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41885/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 2:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1714
>     https://issues.apache.org/jira/browse/FALCON-1714
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> EntityNotRegisteredException when process with no input/output feed is scheduled
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/handler/SLAMonitoringHandler.java bb3b8e0 
> 
> Diff: https://reviews.apache.org/r/41885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>