You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Joe Crobak <jo...@gmail.com> on 2012/05/22 04:48:56 UTC

Review Request: Fix ThriftLegacySource fields->headers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5189/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Fix ThriftLegacySource fields->headers.
    
Field values are lost in the conversion of legacy fields to headers bcause
ByteBuffer.toString() doesn't do what you'd expect.

Refactored some tests to remove duplicate start/stop code that I needed to use.


This addresses bug FLUME-1221.
    https://issues.apache.org/jira/browse/FLUME-1221


Diffs
-----

  flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java 00df7e4 
  flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java ddd9478 

Diff: https://reviews.apache.org/r/5189/diff


Testing
-------

Added a simple unit test. Also tested writing to a file that had a header (from a thrift source) in the path. Worked as expected.


Thanks,

Joe


Re: Review Request: Fix ThriftLegacySource fields->headers.

Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5189/#review8100
-----------------------------------------------------------

Ship it!


+1. Looks good!

- Mike


On 2012-05-22 02:48:55, Joe Crobak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5189/
> -----------------------------------------------------------
> 
> (Updated 2012-05-22 02:48:55)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> Fix ThriftLegacySource fields->headers.
>     
> Field values are lost in the conversion of legacy fields to headers bcause
> ByteBuffer.toString() doesn't do what you'd expect.
> 
> Refactored some tests to remove duplicate start/stop code that I needed to use.
> 
> 
> This addresses bug FLUME-1221.
>     https://issues.apache.org/jira/browse/FLUME-1221
> 
> 
> Diffs
> -----
> 
>   flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java 00df7e4 
>   flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java ddd9478 
> 
> Diff: https://reviews.apache.org/r/5189/diff
> 
> 
> Testing
> -------
> 
> Added a simple unit test. Also tested writing to a file that had a header (from a thrift source) in the path. Worked as expected.
> 
> 
> Thanks,
> 
> Joe
> 
>