You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2013/11/12 20:48:24 UTC
[FALCONJX/FLEXJS] stricter compilation
Hi,
I have a local branch in which I've made the FalconJx 'goog' compiler
apply to the strictest possible rules/flags. This resulted in 193
warnings about bad code in the DataBindingTest example. Hidden behind
those were some more errors ;-)
I fixed all but a couple in the framework and there are some more that
come from the example. All in all there are some 40 warnings left...
The application, meanwhile, is compiled successfully and functions as
expected. These warnings are all about annotations and types and code
structure.
I feel having the stricter compiler flags active will help us write a
better framework. Making the remaining warnings go away is a challenge
I gladly accept.
The question is, can we live with seeing these warnings in the meantime?
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Alex Harui <ah...@adobe.com>.
Fine with me. What will it take to get rid of the remaining 32?
Also, I'm ok with the flag defaulting to true for now. Flex defaults to
-strict already.
-Alex
On 11/13/13 3:01 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>> I've published a 'develop_strictest' branch on both the 'flex-asjs'
>> and 'flex-falcon' projects. These need to live together to make the
>> magic happen.
>
>I fixed as much of the warnings as was possible given our setup. There
>are now 32 warnings left when publishing 'DataBindingTest', most seem
>related to the alternative way FalconJx handles dependencies and to
>type inconsistencies between the AS and JS framework (inherent to the
>way both languages work).
>
>As we can now explain all the warnings and have fixes in place where
>possible, I thought I'd just put the strict flags behind a command
>line argument and merge the changes from 'develop-strictest' back into
>the regular 'develop'. As usual, I borked the git commands a bit, so
>there were a few more commit messages than I intended, but I think the
>end result is correct ;-)
>
>So, we're back to working on 'develop' again. I'll remove
>'develop-strictest' once I've received a ping from you guys.
>
>EdB
>
>
>
>--
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. www.ixsoftware.nl
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Erik de Bruin <er...@ixsoftware.nl>.
> I've published a 'develop_strictest' branch on both the 'flex-asjs'
> and 'flex-falcon' projects. These need to live together to make the
> magic happen.
I fixed as much of the warnings as was possible given our setup. There
are now 32 warnings left when publishing 'DataBindingTest', most seem
related to the alternative way FalconJx handles dependencies and to
type inconsistencies between the AS and JS framework (inherent to the
way both languages work).
As we can now explain all the warnings and have fixes in place where
possible, I thought I'd just put the strict flags behind a command
line argument and merge the changes from 'develop-strictest' back into
the regular 'develop'. As usual, I borked the git commands a bit, so
there were a few more commit messages than I intended, but I think the
end result is correct ;-)
So, we're back to working on 'develop' again. I'll remove
'develop-strictest' once I've received a ping from you guys.
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Tue, Nov 12, 2013 at 4:35 PM, Alex Harui <ah...@adobe.com> wrote:
> Run ant wipe-all first?
>
>
That worked, thanks!
Om
> On 11/12/13 3:43 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >On Tue, Nov 12, 2013 at 12:11 PM, Erik de Bruin <er...@ixsoftware.nl>
> >wrote:
> >
> >> I've published a 'develop_strictest' branch on both the 'flex-asjs'
> >> and 'flex-falcon' projects. These need to live together to make the
> >> magic happen.
> >>
> >> Let me know if it works for you.
> >>
> >> EdB
> >>
> >
> >I havent built falcon in a long time. When I pulled the latest and tried
> >to build flex-falcon, I am getting these errors on both "develop" and
> >"develop_strictest" branches:
> >
> >What am I doing wrong?
> >.
> >.
> >.
> >src.depend:
> > [depend] The class org.apache.flex.compiler.mxml.StateDefinitionBase in
> >file
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\generated\classes
> >\org\a
> >pache\flex\compiler\mxml\StateDefinitionBase.class is out of date due to
> >org.apa
> >che.flex.compiler.internal.definitions.DefinitionBase but has not been
> >deleted b
> >ecause its source file could not be determined
> > [depend] Deleted 333 out of date files in 15 seconds
> >
> >compile:
> > [javac] Compiling 231 source files to
> >C:\p\flex_os\workspace\flexroot\git\fl
> >ex-falcon\compiler\generated\classes
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:66: package
> >com.google.
> >common.cache does not exist
> > [javac] import com.google.common.cache.CacheBuilder;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:67: package
> >com.google.
> >common.cache does not exist
> > [javac] import com.google.common.cache.CacheLoader;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:68: package
> >com.google.
> >common.cache does not exist
> > [javac] import com.google.common.cache.LoadingCache;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:39: package
> >com.google.com
> >mon.cache does not exist
> > [javac] import com.google.common.cache.CacheBuilder;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:40: package
> >com.google.com
> >mon.cache does not exist
> > [javac] import com.google.common.cache.CacheLoader;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:41: package
> >com.google.com
> >mon.cache does not exist
> > [javac] import com.google.common.cache.LoadingCache;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
> >symbol
> >
> > [javac] symbol : class LoadingCache
> > [javac] location: class
> >org.apache.flex.compiler.internal.projects.CompilerP
> >roject
> > [javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
> >CacheB
> >uilder.newBuilder()
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:272: cannot find
> >symbol
> > [javac] symbol : class LoadingCache
> > [javac] location: class
> >org.apache.flex.compiler.internal.scopes.ASProjectSc
> >ope
> > [javac] private final LoadingCache<ICompilationUnit,
> >Collection<IASScope
> >>> compilationUnitToScopeList =
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:34:
> >package co
> >m.google.common.cache does not exist
> > [javac] import com.google.common.cache.Cache;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:35:
> >package co
> >m.google.common.cache does not exist
> > [javac] import com.google.common.cache.CacheBuilder;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:36:
> >package co
> >m.google.common.cache does not exist
> > [javac] import com.google.common.cache.CacheLoader;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:37:
> >package co
> >m.google.common.cache does not exist
> > [javac] import com.google.common.cache.LoadingCache;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:64:
> >cannot fin
> >d symbol
> > [javac] symbol : class LoadingCache
> > [javac] location: class
> >org.apache.flex.compiler.clients.problems.WorkspaceP
> >roblemFormatter
> > [javac] private final LoadingCache<String, FileLineInfo> readers;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:285:
> >cannot fi
> >nd symbol
> > [javac] symbol : class Cache
> > [javac] location: class
> >org.apache.flex.compiler.clients.problems.WorkspaceP
> >roblemFormatter.FileLineInfo
> > [javac] final Cache<Integer, String> cachedLines;
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:93: cannot find
> >symbol
> > [javac] symbol : class CacheLoader
> > [javac] location: class
> >org.apache.flex.compiler.internal.projects.CompilerP
> >roject
> > [javac] static class ScopeCacheLoader extends CacheLoader<ASScope,
> >ASSco
> >peCache>
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:100: method does
> >not ov
> >erride or implement a method from a supertype
> > [javac] @Override
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
> >symbol
> >
> > [javac] symbol : variable CacheBuilder
> > [javac] location: class
> >org.apache.flex.compiler.internal.projects.CompilerP
> >roject
> > [javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
> >CacheB
> >uilder.newBuilder()
> > [javac]
> >^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:276: cannot find
> >symbol
> > [javac] symbol : class CacheLoader
> > [javac] location: class
> >org.apache.flex.compiler.internal.scopes.ASProjectSc
> >ope
> > [javac] new CacheLoader<ICompilationUnit,
> >Collection<IASScope>>(
> >)
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\internal\scopes\ASProjectScope.java:273: cannot find
> >symbol
> > [javac] symbol : variable CacheBuilder
> > [javac] location: class
> >org.apache.flex.compiler.internal.scopes.ASProjectSc
> >ope
> > [javac] CacheBuilder.newBuilder()
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:100:
> >cannot fi
> >nd symbol
> > [javac] symbol : class CacheLoader
> > [javac] location: class
> >org.apache.flex.compiler.clients.problems.WorkspaceP
> >roblemFormatter
> > [javac] new CacheLoader<String, FileLineInfo>()
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:96:
> >cannot fin
> >d symbol
> > [javac] symbol : variable CacheBuilder
> > [javac] location: class
> >org.apache.flex.compiler.clients.problems.WorkspaceP
> >roblemFormatter
> > [javac] readers = CacheBuilder.newBuilder()
> > [javac] ^
> > [javac]
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
> >che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:260:
> >cannot fi
> >nd symbol
> > [javac] symbol : variable CacheBuilder
> > [javac] location: class
> >org.apache.flex.compiler.clients.problems.WorkspaceP
> >roblemFormatter.FileLineInfo
> > [javac] cachedLines = CacheBuilder.newBuilder()
> > [javac] ^
> > [javac] 22 errors
> >
> >BUILD FAILED
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\build.xml:34: The
> >following
> >erro
> >r occurred while executing this line:
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\build.xml:548:
> >Compile
> >failed; see the compiler error output for details.
> >
> >Total time: 56 seconds
> >
> >C:\p\flex_os\workspace\flexroot\git\flex-falcon>
> >
> >
> >
> >>
> >>
> >>
> >> On Tue, Nov 12, 2013 at 8:53 PM, OmPrakash Muppirala
> >> <bi...@gmail.com> wrote:
> >> > On Tue, Nov 12, 2013 at 11:48 AM, Erik de Bruin <er...@ixsoftware.nl>
> >> wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> I have a local branch in which I've made the FalconJx 'goog' compiler
> >> >> apply to the strictest possible rules/flags. This resulted in 193
> >> >> warnings about bad code in the DataBindingTest example. Hidden behind
> >> >> those were some more errors ;-)
> >> >>
> >> >> I fixed all but a couple in the framework and there are some more
> >>that
> >> >> come from the example. All in all there are some 40 warnings left...
> >> >>
> >> >> The application, meanwhile, is compiled successfully and functions as
> >> >> expected. These warnings are all about annotations and types and code
> >> >> structure.
> >> >>
> >> >> I feel having the stricter compiler flags active will help us write a
> >> >> better framework. Making the remaining warnings go away is a
> >>challenge
> >> >> I gladly accept.
> >> >>
> >> >> The question is, can we live with seeing these warnings in the
> >>meantime?
> >> >>
> >> >>
> >> > I just got my DataBindingTest project up and running. I have been
> >> thinking
> >> > of ways I can help out. If no else one has objections, I can help
> >>with
> >> > this clean up of the warnings.
> >> > Maybe you can push your branch so we can work together on it?
> >> >
> >> > Thanks,
> >> > Om
> >> >
> >> >
> >> >> EdB
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Ix Multimedia Software
> >> >>
> >> >> Jan Luykenstraat 27
> >> >> 3521 VB Utrecht
> >> >>
> >> >> T. 06-51952295
> >> >> I. www.ixsoftware.nl
> >> >>
> >>
> >>
> >>
> >> --
> >> Ix Multimedia Software
> >>
> >> Jan Luykenstraat 27
> >> 3521 VB Utrecht
> >>
> >> T. 06-51952295
> >> I. www.ixsoftware.nl
> >>
>
>
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Alex Harui <ah...@adobe.com>.
Run ant wipe-all first?
On 11/12/13 3:43 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>On Tue, Nov 12, 2013 at 12:11 PM, Erik de Bruin <er...@ixsoftware.nl>
>wrote:
>
>> I've published a 'develop_strictest' branch on both the 'flex-asjs'
>> and 'flex-falcon' projects. These need to live together to make the
>> magic happen.
>>
>> Let me know if it works for you.
>>
>> EdB
>>
>
>I havent built falcon in a long time. When I pulled the latest and tried
>to build flex-falcon, I am getting these errors on both "develop" and
>"develop_strictest" branches:
>
>What am I doing wrong?
>.
>.
>.
>src.depend:
> [depend] The class org.apache.flex.compiler.mxml.StateDefinitionBase in
>file
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\generated\classes
>\org\a
>pache\flex\compiler\mxml\StateDefinitionBase.class is out of date due to
>org.apa
>che.flex.compiler.internal.definitions.DefinitionBase but has not been
>deleted b
>ecause its source file could not be determined
> [depend] Deleted 333 out of date files in 15 seconds
>
>compile:
> [javac] Compiling 231 source files to
>C:\p\flex_os\workspace\flexroot\git\fl
>ex-falcon\compiler\generated\classes
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:66: package
>com.google.
>common.cache does not exist
> [javac] import com.google.common.cache.CacheBuilder;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:67: package
>com.google.
>common.cache does not exist
> [javac] import com.google.common.cache.CacheLoader;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:68: package
>com.google.
>common.cache does not exist
> [javac] import com.google.common.cache.LoadingCache;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:39: package
>com.google.com
>mon.cache does not exist
> [javac] import com.google.common.cache.CacheBuilder;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:40: package
>com.google.com
>mon.cache does not exist
> [javac] import com.google.common.cache.CacheLoader;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:41: package
>com.google.com
>mon.cache does not exist
> [javac] import com.google.common.cache.LoadingCache;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
>symbol
>
> [javac] symbol : class LoadingCache
> [javac] location: class
>org.apache.flex.compiler.internal.projects.CompilerP
>roject
> [javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
>CacheB
>uilder.newBuilder()
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:272: cannot find
>symbol
> [javac] symbol : class LoadingCache
> [javac] location: class
>org.apache.flex.compiler.internal.scopes.ASProjectSc
>ope
> [javac] private final LoadingCache<ICompilationUnit,
>Collection<IASScope
>>> compilationUnitToScopeList =
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:34:
>package co
>m.google.common.cache does not exist
> [javac] import com.google.common.cache.Cache;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:35:
>package co
>m.google.common.cache does not exist
> [javac] import com.google.common.cache.CacheBuilder;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:36:
>package co
>m.google.common.cache does not exist
> [javac] import com.google.common.cache.CacheLoader;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:37:
>package co
>m.google.common.cache does not exist
> [javac] import com.google.common.cache.LoadingCache;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:64:
>cannot fin
>d symbol
> [javac] symbol : class LoadingCache
> [javac] location: class
>org.apache.flex.compiler.clients.problems.WorkspaceP
>roblemFormatter
> [javac] private final LoadingCache<String, FileLineInfo> readers;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:285:
>cannot fi
>nd symbol
> [javac] symbol : class Cache
> [javac] location: class
>org.apache.flex.compiler.clients.problems.WorkspaceP
>roblemFormatter.FileLineInfo
> [javac] final Cache<Integer, String> cachedLines;
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:93: cannot find
>symbol
> [javac] symbol : class CacheLoader
> [javac] location: class
>org.apache.flex.compiler.internal.projects.CompilerP
>roject
> [javac] static class ScopeCacheLoader extends CacheLoader<ASScope,
>ASSco
>peCache>
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:100: method does
>not ov
>erride or implement a method from a supertype
> [javac] @Override
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
>symbol
>
> [javac] symbol : variable CacheBuilder
> [javac] location: class
>org.apache.flex.compiler.internal.projects.CompilerP
>roject
> [javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
>CacheB
>uilder.newBuilder()
> [javac]
>^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:276: cannot find
>symbol
> [javac] symbol : class CacheLoader
> [javac] location: class
>org.apache.flex.compiler.internal.scopes.ASProjectSc
>ope
> [javac] new CacheLoader<ICompilationUnit,
>Collection<IASScope>>(
>)
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\internal\scopes\ASProjectScope.java:273: cannot find
>symbol
> [javac] symbol : variable CacheBuilder
> [javac] location: class
>org.apache.flex.compiler.internal.scopes.ASProjectSc
>ope
> [javac] CacheBuilder.newBuilder()
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:100:
>cannot fi
>nd symbol
> [javac] symbol : class CacheLoader
> [javac] location: class
>org.apache.flex.compiler.clients.problems.WorkspaceP
>roblemFormatter
> [javac] new CacheLoader<String, FileLineInfo>()
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:96:
>cannot fin
>d symbol
> [javac] symbol : variable CacheBuilder
> [javac] location: class
>org.apache.flex.compiler.clients.problems.WorkspaceP
>roblemFormatter
> [javac] readers = CacheBuilder.newBuilder()
> [javac] ^
> [javac]
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
>che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:260:
>cannot fi
>nd symbol
> [javac] symbol : variable CacheBuilder
> [javac] location: class
>org.apache.flex.compiler.clients.problems.WorkspaceP
>roblemFormatter.FileLineInfo
> [javac] cachedLines = CacheBuilder.newBuilder()
> [javac] ^
> [javac] 22 errors
>
>BUILD FAILED
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\build.xml:34: The
>following
>erro
>r occurred while executing this line:
>C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\build.xml:548:
>Compile
>failed; see the compiler error output for details.
>
>Total time: 56 seconds
>
>C:\p\flex_os\workspace\flexroot\git\flex-falcon>
>
>
>
>>
>>
>>
>> On Tue, Nov 12, 2013 at 8:53 PM, OmPrakash Muppirala
>> <bi...@gmail.com> wrote:
>> > On Tue, Nov 12, 2013 at 11:48 AM, Erik de Bruin <er...@ixsoftware.nl>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> I have a local branch in which I've made the FalconJx 'goog' compiler
>> >> apply to the strictest possible rules/flags. This resulted in 193
>> >> warnings about bad code in the DataBindingTest example. Hidden behind
>> >> those were some more errors ;-)
>> >>
>> >> I fixed all but a couple in the framework and there are some more
>>that
>> >> come from the example. All in all there are some 40 warnings left...
>> >>
>> >> The application, meanwhile, is compiled successfully and functions as
>> >> expected. These warnings are all about annotations and types and code
>> >> structure.
>> >>
>> >> I feel having the stricter compiler flags active will help us write a
>> >> better framework. Making the remaining warnings go away is a
>>challenge
>> >> I gladly accept.
>> >>
>> >> The question is, can we live with seeing these warnings in the
>>meantime?
>> >>
>> >>
>> > I just got my DataBindingTest project up and running. I have been
>> thinking
>> > of ways I can help out. If no else one has objections, I can help
>>with
>> > this clean up of the warnings.
>> > Maybe you can push your branch so we can work together on it?
>> >
>> > Thanks,
>> > Om
>> >
>> >
>> >> EdB
>> >>
>> >>
>> >>
>> >> --
>> >> Ix Multimedia Software
>> >>
>> >> Jan Luykenstraat 27
>> >> 3521 VB Utrecht
>> >>
>> >> T. 06-51952295
>> >> I. www.ixsoftware.nl
>> >>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Tue, Nov 12, 2013 at 12:11 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> I've published a 'develop_strictest' branch on both the 'flex-asjs'
> and 'flex-falcon' projects. These need to live together to make the
> magic happen.
>
> Let me know if it works for you.
>
> EdB
>
I havent built falcon in a long time. When I pulled the latest and tried
to build flex-falcon, I am getting these errors on both "develop" and
"develop_strictest" branches:
What am I doing wrong?
.
.
.
src.depend:
[depend] The class org.apache.flex.compiler.mxml.StateDefinitionBase in
file
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\generated\classes\org\a
pache\flex\compiler\mxml\StateDefinitionBase.class is out of date due to
org.apa
che.flex.compiler.internal.definitions.DefinitionBase but has not been
deleted b
ecause its source file could not be determined
[depend] Deleted 333 out of date files in 15 seconds
compile:
[javac] Compiling 231 source files to
C:\p\flex_os\workspace\flexroot\git\fl
ex-falcon\compiler\generated\classes
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:66: package
com.google.
common.cache does not exist
[javac] import com.google.common.cache.CacheBuilder;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:67: package
com.google.
common.cache does not exist
[javac] import com.google.common.cache.CacheLoader;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:68: package
com.google.
common.cache does not exist
[javac] import com.google.common.cache.LoadingCache;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:39: package
com.google.com
mon.cache does not exist
[javac] import com.google.common.cache.CacheBuilder;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:40: package
com.google.com
mon.cache does not exist
[javac] import com.google.common.cache.CacheLoader;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:41: package
com.google.com
mon.cache does not exist
[javac] import com.google.common.cache.LoadingCache;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
symbol
[javac] symbol : class LoadingCache
[javac] location: class
org.apache.flex.compiler.internal.projects.CompilerP
roject
[javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
CacheB
uilder.newBuilder()
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:272: cannot find
symbol
[javac] symbol : class LoadingCache
[javac] location: class
org.apache.flex.compiler.internal.scopes.ASProjectSc
ope
[javac] private final LoadingCache<ICompilationUnit,
Collection<IASScope
>> compilationUnitToScopeList =
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:34:
package co
m.google.common.cache does not exist
[javac] import com.google.common.cache.Cache;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:35:
package co
m.google.common.cache does not exist
[javac] import com.google.common.cache.CacheBuilder;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:36:
package co
m.google.common.cache does not exist
[javac] import com.google.common.cache.CacheLoader;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:37:
package co
m.google.common.cache does not exist
[javac] import com.google.common.cache.LoadingCache;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:64:
cannot fin
d symbol
[javac] symbol : class LoadingCache
[javac] location: class
org.apache.flex.compiler.clients.problems.WorkspaceP
roblemFormatter
[javac] private final LoadingCache<String, FileLineInfo> readers;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:285:
cannot fi
nd symbol
[javac] symbol : class Cache
[javac] location: class
org.apache.flex.compiler.clients.problems.WorkspaceP
roblemFormatter.FileLineInfo
[javac] final Cache<Integer, String> cachedLines;
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:93: cannot find
symbol
[javac] symbol : class CacheLoader
[javac] location: class
org.apache.flex.compiler.internal.projects.CompilerP
roject
[javac] static class ScopeCacheLoader extends CacheLoader<ASScope,
ASSco
peCache>
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:100: method does
not ov
erride or implement a method from a supertype
[javac] @Override
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\projects\CompilerProject.java:114: cannot find
symbol
[javac] symbol : variable CacheBuilder
[javac] location: class
org.apache.flex.compiler.internal.projects.CompilerP
roject
[javac] private LoadingCache<ASScope, ASScopeCache> scopeCaches =
CacheB
uilder.newBuilder()
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:276: cannot find
symbol
[javac] symbol : class CacheLoader
[javac] location: class
org.apache.flex.compiler.internal.scopes.ASProjectSc
ope
[javac] new CacheLoader<ICompilationUnit,
Collection<IASScope>>(
)
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\internal\scopes\ASProjectScope.java:273: cannot find
symbol
[javac] symbol : variable CacheBuilder
[javac] location: class
org.apache.flex.compiler.internal.scopes.ASProjectSc
ope
[javac] CacheBuilder.newBuilder()
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:100:
cannot fi
nd symbol
[javac] symbol : class CacheLoader
[javac] location: class
org.apache.flex.compiler.clients.problems.WorkspaceP
roblemFormatter
[javac] new CacheLoader<String, FileLineInfo>()
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:96:
cannot fin
d symbol
[javac] symbol : variable CacheBuilder
[javac] location: class
org.apache.flex.compiler.clients.problems.WorkspaceP
roblemFormatter
[javac] readers = CacheBuilder.newBuilder()
[javac] ^
[javac]
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\src\org\apa
che\flex\compiler\clients\problems\WorkspaceProblemFormatter.java:260:
cannot fi
nd symbol
[javac] symbol : variable CacheBuilder
[javac] location: class
org.apache.flex.compiler.clients.problems.WorkspaceP
roblemFormatter.FileLineInfo
[javac] cachedLines = CacheBuilder.newBuilder()
[javac] ^
[javac] 22 errors
BUILD FAILED
C:\p\flex_os\workspace\flexroot\git\flex-falcon\build.xml:34: The following
erro
r occurred while executing this line:
C:\p\flex_os\workspace\flexroot\git\flex-falcon\compiler\build.xml:548:
Compile
failed; see the compiler error output for details.
Total time: 56 seconds
C:\p\flex_os\workspace\flexroot\git\flex-falcon>
>
>
>
> On Tue, Nov 12, 2013 at 8:53 PM, OmPrakash Muppirala
> <bi...@gmail.com> wrote:
> > On Tue, Nov 12, 2013 at 11:48 AM, Erik de Bruin <er...@ixsoftware.nl>
> wrote:
> >
> >> Hi,
> >>
> >> I have a local branch in which I've made the FalconJx 'goog' compiler
> >> apply to the strictest possible rules/flags. This resulted in 193
> >> warnings about bad code in the DataBindingTest example. Hidden behind
> >> those were some more errors ;-)
> >>
> >> I fixed all but a couple in the framework and there are some more that
> >> come from the example. All in all there are some 40 warnings left...
> >>
> >> The application, meanwhile, is compiled successfully and functions as
> >> expected. These warnings are all about annotations and types and code
> >> structure.
> >>
> >> I feel having the stricter compiler flags active will help us write a
> >> better framework. Making the remaining warnings go away is a challenge
> >> I gladly accept.
> >>
> >> The question is, can we live with seeing these warnings in the meantime?
> >>
> >>
> > I just got my DataBindingTest project up and running. I have been
> thinking
> > of ways I can help out. If no else one has objections, I can help with
> > this clean up of the warnings.
> > Maybe you can push your branch so we can work together on it?
> >
> > Thanks,
> > Om
> >
> >
> >> EdB
> >>
> >>
> >>
> >> --
> >> Ix Multimedia Software
> >>
> >> Jan Luykenstraat 27
> >> 3521 VB Utrecht
> >>
> >> T. 06-51952295
> >> I. www.ixsoftware.nl
> >>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I've published a 'develop_strictest' branch on both the 'flex-asjs'
and 'flex-falcon' projects. These need to live together to make the
magic happen.
Let me know if it works for you.
EdB
On Tue, Nov 12, 2013 at 8:53 PM, OmPrakash Muppirala
<bi...@gmail.com> wrote:
> On Tue, Nov 12, 2013 at 11:48 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>
>> Hi,
>>
>> I have a local branch in which I've made the FalconJx 'goog' compiler
>> apply to the strictest possible rules/flags. This resulted in 193
>> warnings about bad code in the DataBindingTest example. Hidden behind
>> those were some more errors ;-)
>>
>> I fixed all but a couple in the framework and there are some more that
>> come from the example. All in all there are some 40 warnings left...
>>
>> The application, meanwhile, is compiled successfully and functions as
>> expected. These warnings are all about annotations and types and code
>> structure.
>>
>> I feel having the stricter compiler flags active will help us write a
>> better framework. Making the remaining warnings go away is a challenge
>> I gladly accept.
>>
>> The question is, can we live with seeing these warnings in the meantime?
>>
>>
> I just got my DataBindingTest project up and running. I have been thinking
> of ways I can help out. If no else one has objections, I can help with
> this clean up of the warnings.
> Maybe you can push your branch so we can work together on it?
>
> Thanks,
> Om
>
>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Tue, Nov 12, 2013 at 11:48 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Hi,
>
> I have a local branch in which I've made the FalconJx 'goog' compiler
> apply to the strictest possible rules/flags. This resulted in 193
> warnings about bad code in the DataBindingTest example. Hidden behind
> those were some more errors ;-)
>
> I fixed all but a couple in the framework and there are some more that
> come from the example. All in all there are some 40 warnings left...
>
> The application, meanwhile, is compiled successfully and functions as
> expected. These warnings are all about annotations and types and code
> structure.
>
> I feel having the stricter compiler flags active will help us write a
> better framework. Making the remaining warnings go away is a challenge
> I gladly accept.
>
> The question is, can we live with seeing these warnings in the meantime?
>
>
I just got my DataBindingTest project up and running. I have been thinking
of ways I can help out. If no else one has objections, I can help with
this clean up of the warnings.
Maybe you can push your branch so we can work together on it?
Thanks,
Om
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Erik de Bruin <er...@ixsoftware.nl>.
>>I have a local branch in which I've made the FalconJx 'goog' compiler
>>apply to the strictest possible rules/flags. This resulted in 193
>>warnings about bad code in the DataBindingTest example. Hidden behind
>>those were some more errors ;-)
> Is it an option you can turn on and off? Customer's may not always want
> their code compiled strictly.
I added a command line argument '-strict-publish' to control this. The
default is off, so if you don't add the argument, the 'old' set of
compiler flags will be used and you shouldn't see any extra warnings.
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [FALCONJX/FLEXJS] stricter compilation
Posted by Alex Harui <ah...@adobe.com>.
On 11/12/13 11:48 AM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>Hi,
>
>I have a local branch in which I've made the FalconJx 'goog' compiler
>apply to the strictest possible rules/flags. This resulted in 193
>warnings about bad code in the DataBindingTest example. Hidden behind
>those were some more errors ;-)
Is it an option you can turn on and off? Customer's may not always want
their code compiled strictly.
>
>The question is, can we live with seeing these warnings in the meantime?
I'm ok with it.
-Alex