You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/09/04 04:21:22 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #34063: Bring back SHUTDOWN-related constants
uranusjr opened a new pull request, #34063:
URL: https://github.com/apache/airflow/pull/34063
This should restore code compatibility to 2.6 and prior. Note that the constants would not appear in documentation since they are deprecated and not use in Airflow core anyway anymore.
See discussion around https://github.com/apache/airflow/pull/33746#issuecomment-1698956131
I added some additional docstrings so those constants would not appear in documentation added in #34059. Those who already know about the values can continue to use them, but this should reduce additional usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34063: Bring back SHUTDOWN-related constants
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34063:
URL: https://github.com/apache/airflow/pull/34063#issuecomment-1704746038
Pending test fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #34063: Bring back SHUTDOWN-related constants
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #34063:
URL: https://github.com/apache/airflow/pull/34063#discussion_r1314614951
##########
airflow/utils/state.py:
##########
@@ -58,6 +58,13 @@ class TaskInstanceState(str, Enum):
SKIPPED = "skipped" # Skipped by branching or some other mechanism
DEFERRED = "deferred" # Deferrable operator waiting on a trigger
+ # Not used anymore, kept for compatibility.
Review Comment:
Not _that_ useful since I’d assume the cleanup process would involve searching for `:meta private:` anyway. But a comment is easy and would not hurt.
##########
airflow/utils/state.py:
##########
@@ -58,6 +58,13 @@ class TaskInstanceState(str, Enum):
SKIPPED = "skipped" # Skipped by branching or some other mechanism
DEFERRED = "deferred" # Deferrable operator waiting on a trigger
+ # Not used anymore, kept for compatibility.
Review Comment:
Not _that_ useful since I’d assume the cleanup process would involve searching for `:meta private:` anyway. But a comment is easy and would not hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Lee-W commented on a diff in pull request #34063: Bring back SHUTDOWN-related constants
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #34063:
URL: https://github.com/apache/airflow/pull/34063#discussion_r1314567217
##########
airflow/utils/state.py:
##########
@@ -58,6 +58,13 @@ class TaskInstanceState(str, Enum):
SKIPPED = "skipped" # Skipped by branching or some other mechanism
DEFERRED = "deferred" # Deferrable operator waiting on a trigger
+ # Not used anymore, kept for compatibility.
Review Comment:
According to https://github.com/apache/airflow/pull/33746#issuecomment-1698956131, should we add a comment to remind us to remove it on the next major release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34063: Bring back SHUTDOWN-related constants
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34063:
URL: https://github.com/apache/airflow/pull/34063#issuecomment-1705647745
> The failing test is a known flaky test so re-run or merge with main might fix it
BTW. I **think** I fixed the flaky test in #34075 so likely rebasing it woudl be flaky-free, but I re-run those failing tests now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #34063: Bring back SHUTDOWN-related constants
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34063:
URL: https://github.com/apache/airflow/pull/34063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org