You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/06 12:36:46 UTC

[GitHub] [spark] jerqi opened a new pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

jerqi opened a new pull request #33230:
URL: https://github.com/apache/spark/pull/33230


   backport #33204 to 3.1
   
   ### What changes were proposed in this pull request?
   PR #15764 disabled creating permanent views based on temporary views or UDFs.  But AlterViewCommand didn't block temporary objects.
   
   ### Why are the changes needed?
   More robust view canonicalization.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, now if you alter a permanent view based on temporary views or UDFs, the operation will fail.
   
   ### How was this patch tested?
   Add new unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33230:
URL: https://github.com/apache/spark/pull/33230#issuecomment-876595206


   But this can break a case that could look like working without a problem, and I wouldn't expect such cases in maintenence release. We banned such cases because of a potential unexpected behaviour, right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33230:
URL: https://github.com/apache/spark/pull/33230#issuecomment-876541457


   This is a bug. A permanent view referring to temp objects is malformed. We shouldn't allow it to exist. We ban it in CREATE VIEW but forgot about ALTER VIEW.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33230:
URL: https://github.com/apache/spark/pull/33230#issuecomment-876615644


   The malformed permanent view is almost useless, as you can't access it in another Spark application (that's the major use case of a "permanent" view), or another Spark session. This PR is more like "fail earlier" to improve user experience.
   
   Anyway, I don't have a strong opinion on it, as it's not a big deal. If there are objections, let's close and not merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] jerqi closed pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
jerqi closed pull request #33230:
URL: https://github.com/apache/spark/pull/33230


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33230:
URL: https://github.com/apache/spark/pull/33230#issuecomment-874737431


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33230: [SPARK-36011][SQL][3.1] Disallow altering permanent views based on temporary views or UDFs

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33230:
URL: https://github.com/apache/spark/pull/33230#issuecomment-876132723


   This is a breaking change. why would we want to backport? I wouldn't.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org