You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/10 18:32:54 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request #14646: [tests] reduce ManagedLedgerFactoryShutdownTest flakyness
nicoloboschi opened a new pull request #14646:
URL: https://github.com/apache/pulsar/pull/14646
### Motivation
ManagedLedgerFactoryShutdownTest#openEncounteredShutdown is flaky. I've seen failing that due to timeout.
```
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.941 s <<< FAILURE! - in org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryShutdownTest
[ERROR] openEncounteredShutdown(org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryShutdownTest) Time elapsed: 5.033 s <<< FAILURE!
org.testng.internal.thread.ThreadTimeoutException: Method org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryShutdownTest.openEncounteredShutdown() didn't finish within the time-out 5000
```
After investigating I found out that the first Mockito `mock` call takes more than 2-3 seconds.
Mockito setup should be done in the @BeforeMethod and leave the timeout to the managed ledger logic.
### Modifications
* Moved the the mockito setup to the @BeforeMethod method
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14646: [tests] reduce ManagedLedgerFactoryShutdownTest flakyness
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14646:
URL: https://github.com/apache/pulsar/pull/14646#issuecomment-1064469657
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14646: [tests] reduce ManagedLedgerFactoryShutdownTest flakyness
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14646:
URL: https://github.com/apache/pulsar/pull/14646#issuecomment-1064835291
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #14646: [tests] reduce ManagedLedgerFactoryShutdownTest flakyness
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #14646:
URL: https://github.com/apache/pulsar/pull/14646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org