You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by da...@apache.org on 2021/06/03 08:34:38 UTC
Re: [Discuss] Moving the Converter implementation to OSGi at Eclipse
Hi all,
The OSGi Converter has now moved to
https://github.com/osgi/osgi/tree/main/org.osgi.util.converter and patches
are most welcome :)
I've removed the files from the Felix codebase
https://github.com/apache/felix-dev/commit/143ba444db23ca1746a8e28824025bb6b2327ca8
however they are still present in the project history, of course.
Snapshots can be picked up from
https://oss.sonatype.org/content/repositories/snapshots/org/osgi/org.osgi.util.converter/
Best regards,
David
On Thu, 27 May 2021 at 09:18, <da...@apache.org> wrote:
> Hi all,
>
> Thanks for the discussion. I'll initiate the migration of the
> converter/converter codebase as discussed.
>
> Kind regards,
>
> David Bosschaert
>
> On Mon, 10 May 2021 at 23:49, David Leangen <os...@leangen.net> wrote:
>
>>
>> Hey David,
>>
>> Ok, thanks!
>>
>> =David
>>
>>
>>
>> > On May 10, 2021, at 21:25, David Bosschaert <da...@gmail.com>
>> wrote:
>> >
>> > Hi David,
>> >
>> > Under the 'converter' umbrella in Felix there are 3 subprojects besides
>> the
>> > converter itself:
>> > * serializer
>> > * schematizer
>> > * persister
>> >
>> > I personally think it would be absolutely fine to leave them in Apache
>> > Felix. They build atop the converter. The converter API itself doesn't
>> > change in any way, so these components can just stay where they are...
>> >
>> > Does that make sense to you?
>> >
>> > Cheers,
>> >
>> > David
>> >
>> > On Mon, 10 May 2021 at 11:24, David Leangen (OSGi) <os...@leangen.net>
>> wrote:
>> >
>> >> Hey David,
>> >>
>> >> Thanks as always for all your great contributions.
>> >>
>> >> I was just wondering about the Serializer. Although I have not put any
>> >> work into for a while (including releasing, which I have not yet
>> managed to
>> >> get set up to do), I at least still use it, and I still think it is a
>> >> useful, even necessary tool. Unless you know of something else that
>> does
>> >> the job?
>> >>
>> >> Cheers,
>> >> =David
>> >>
>> >> What one programmer can do in one month, two programmers can do in two
>> >> months. (Fred Brooks)
>> >>
>> >> On May 7, 2021 18:18 +0900, davidb@apache.org, wrote:
>> >>> Hi JB,
>> >>>
>> >>> Some of the contributors of the Converter at Felix are already
>> committers
>> >>> at the Eclipse project [5].
>> >>> Others can just create PRs for any changes to the
>> >>> https://github.com/osgi/osgi/ project. As it's an opensource project
>> you
>> >>> can earn committer karma the usual open-source way.
>> >>> I have done a quick commit grep and found that of the 200 commits to
>> the
>> >>> converter there are 13 made by people who are not already committers
>> at
>> >> the
>> >>> OSGi project at Eclipse.
>> >>>
>> >>> I have also checked with Eclipse around releasing the component. Any
>> >> fixes
>> >>> that don't impact the API, i.e. micro-version releases can be done
>> from
>> >> an
>> >>> Eclipse project pretty much any time. Fixes that do impact the API
>> would
>> >>> also need a specification update.
>> >>>
>> >>> Best regards,
>> >>>
>> >>> David
>> >>>
>> >>> [5] https://projects.eclipse.org/projects/technology.osgi/who
>> >>>
>> >>> On Thu, 6 May 2021 at 16:23, Jean-Baptiste Onofre <jb...@nanthrax.net>
>> >> wrote:
>> >>>
>> >>>> Hi David,
>> >>>>
>> >>>> It makes sense and it would be more "consistent" to have a single
>> >>>> repository.
>> >>>>
>> >>>> As Converter is part of the "spec", it makes sense to be located at
>> >>>> Eclipse.
>> >>>>
>> >>>> My only "concern" is about the contributions/contributors on Felix
>> >>>> Converter.
>> >>>> Will all Felix committers be able to change/maintain code at Eclipse
>> >> (the
>> >>>> code coming from Felix Converter) ?
>> >>>>
>> >>>> Regards
>> >>>> JB
>> >>>>
>> >>>>> Le 6 mai 2021 à 17:17, davidb@apache.org a écrit :
>> >>>>>
>> >>>>> Hi all,
>> >>>>>
>> >>>>> As most would have noticed, OSGi has moved to the Eclipse Foundation
>> >> [1]
>> >>>>> and all the future OSGi specification work will happen there [2].
>> >>>>>
>> >>>>> The Converter that's in the Felix codebase is an implementation of
>> >> the
>> >>>> OSGi
>> >>>>> Converter specification [3]. As Converter is a 'util' specification,
>> >> OSGi
>> >>>>> also provides an implementation with the API. There could be other
>> >>>>> implementations as well, this is similar to what is done with Push
>> >>>> Streams
>> >>>>> and the Service Tracker.
>> >>>>>
>> >>>>> The initial implementation of the Converter Util at OSGi was based
>> >> on the
>> >>>>> same codebase as the Converter at Felix. In effect it's a fork. Over
>> >> time
>> >>>>> the two forks have started to diverge a little, mostly due to
>> >> different
>> >>>>> fixes being applied to both of them.
>> >>>>>
>> >>>>> Now that OSGi is an Eclipse project and all of the OSGi technology
>> at
>> >>>>> Eclipse is developed as ordinary opensource projects with the ASL2
>> >>>> license
>> >>>>> I think it would be good if we could collapse these 2 forks into one
>> >>>> again.
>> >>>>> Because the Converter is the implementation shipped by OSGi as part
>> >> of
>> >>>> its
>> >>>>> spec API (into [4]), we can't really remove the implementation from
>> >> the
>> >>>>> OSGi codebase.
>> >>>>> So I would like to discuss removing the Converter from the Felix
>> >>>> codebase,
>> >>>>> so that the codebase can live on in a single location which would
>> be:
>> >>>>>
>> >>>>
>> >>
>> https://github.com/osgi/osgi/tree/main/org.osgi.util.converter/src/org/osgi/util/converter
>> >>>>>
>> >>>>> Obviously this would mean to consolidate all the bugfixes that went
>> >> into
>> >>>>> its Felix codebase into the combined one.
>> >>>>> Combining the codebases into one would mean that all users get the
>> >>>> benefit
>> >>>>> from work done to the implementation by both communities.
>> >>>>>
>> >>>>> I hope that the Felix community would be open to this.
>> >>>>>
>> >>>>> Best regards,
>> >>>>>
>> >>>>> David Bosschaert
>> >>>>>
>> >>>>> [1]
>> >>>>>
>> >>>>
>> >>
>> https://newsroom.eclipse.org/news/announcements/osgi-alliance-transfers-governance-osgi-specifications-open-source-software
>> >>>>> [2] https://projects.eclipse.org/projects/technology.osgi
>> >>>>> [3]
>> >>>>
>> >>
>> https://docs.osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html
>> >>>>> [4]
>> https://repo1.maven.org/maven2/org/osgi/org.osgi.util.converter/
>> >>>>
>> >>>>
>> >>
>>
>>
Re: [Discuss] Moving the Converter implementation to OSGi at Eclipse
Posted by da...@apache.org.
Hi Konrad, all,
While doing bugfix releases of the Converter should normally be easy at
OSGi in Eclipse I just found out that you can only do a Service Release in
Eclipse once a first actual release has been done. As per the Eclipse
Process [5] you need a 'Major or Minor' release first.
Right now, we're only at the start of OSGi's life at Eclipse and there is
no release just yet. The first is planned for Q3, 2021.
So until then, I would suggest that we do any patch releases here in Felix
- I'm happy to kick one off as requested, Konrad.
Once the first OSGi releases are done at Eclipse, this problem should go
away.
Best regards,
David
[5] https://www.eclipse.org/projects/efsp/#efsp-terms
On Thu, 3 Jun 2021 at 11:06, <da...@apache.org> wrote:
> Hi Konrad,
>
> I'll look into that.
>
> Cheers,
>
> David
>
> On Thu, 3 Jun 2021 at 10:17, Konrad Windszus <ko...@gmx.de> wrote:
>
>> Hi David,
>> thanks for doing the merge. Can you spin a release now? What is the
>> release process at Eclipse?
>> Regards,
>> Konrad
>>
>> > On 3. Jun 2021, at 10:34, davidb@apache.org wrote:
>> >
>> > Hi all,
>> >
>> > The OSGi Converter has now moved to
>> > https://github.com/osgi/osgi/tree/main/org.osgi.util.converter and
>> patches
>> > are most welcome :)
>> >
>> > I've removed the files from the Felix codebase
>> >
>> https://github.com/apache/felix-dev/commit/143ba444db23ca1746a8e28824025bb6b2327ca8
>> > however they are still present in the project history, of course.
>> >
>> > Snapshots can be picked up from
>> >
>> https://oss.sonatype.org/content/repositories/snapshots/org/osgi/org.osgi.util.converter/
>> >
>> > Best regards,
>> >
>> > David
>> >
>> > On Thu, 27 May 2021 at 09:18, <da...@apache.org> wrote:
>> >
>> >> Hi all,
>> >>
>> >> Thanks for the discussion. I'll initiate the migration of the
>> >> converter/converter codebase as discussed.
>> >>
>> >> Kind regards,
>> >>
>> >> David Bosschaert
>> >>
>> >> On Mon, 10 May 2021 at 23:49, David Leangen <os...@leangen.net> wrote:
>> >>
>> >>>
>> >>> Hey David,
>> >>>
>> >>> Ok, thanks!
>> >>>
>> >>> =David
>> >>>
>> >>>
>> >>>
>> >>>> On May 10, 2021, at 21:25, David Bosschaert <
>> david.bosschaert@gmail.com>
>> >>> wrote:
>> >>>>
>> >>>> Hi David,
>> >>>>
>> >>>> Under the 'converter' umbrella in Felix there are 3 subprojects
>> besides
>> >>> the
>> >>>> converter itself:
>> >>>> * serializer
>> >>>> * schematizer
>> >>>> * persister
>> >>>>
>> >>>> I personally think it would be absolutely fine to leave them in
>> Apache
>> >>>> Felix. They build atop the converter. The converter API itself
>> doesn't
>> >>>> change in any way, so these components can just stay where they
>> are...
>> >>>>
>> >>>> Does that make sense to you?
>> >>>>
>> >>>> Cheers,
>> >>>>
>> >>>> David
>> >>>>
>> >>>> On Mon, 10 May 2021 at 11:24, David Leangen (OSGi) <osgi@leangen.net
>> >
>> >>> wrote:
>> >>>>
>> >>>>> Hey David,
>> >>>>>
>> >>>>> Thanks as always for all your great contributions.
>> >>>>>
>> >>>>> I was just wondering about the Serializer. Although I have not put
>> any
>> >>>>> work into for a while (including releasing, which I have not yet
>> >>> managed to
>> >>>>> get set up to do), I at least still use it, and I still think it is
>> a
>> >>>>> useful, even necessary tool. Unless you know of something else that
>> >>> does
>> >>>>> the job?
>> >>>>>
>> >>>>> Cheers,
>> >>>>> =David
>> >>>>>
>> >>>>> What one programmer can do in one month, two programmers can do in
>> two
>> >>>>> months. (Fred Brooks)
>> >>>>>
>> >>>>> On May 7, 2021 18:18 +0900, davidb@apache.org, wrote:
>> >>>>>> Hi JB,
>> >>>>>>
>> >>>>>> Some of the contributors of the Converter at Felix are already
>> >>> committers
>> >>>>>> at the Eclipse project [5].
>> >>>>>> Others can just create PRs for any changes to the
>> >>>>>> https://github.com/osgi/osgi/ project. As it's an opensource
>> project
>> >>> you
>> >>>>>> can earn committer karma the usual open-source way.
>> >>>>>> I have done a quick commit grep and found that of the 200 commits
>> to
>> >>> the
>> >>>>>> converter there are 13 made by people who are not already
>> committers
>> >>> at
>> >>>>> the
>> >>>>>> OSGi project at Eclipse.
>> >>>>>>
>> >>>>>> I have also checked with Eclipse around releasing the component.
>> Any
>> >>>>> fixes
>> >>>>>> that don't impact the API, i.e. micro-version releases can be done
>> >>> from
>> >>>>> an
>> >>>>>> Eclipse project pretty much any time. Fixes that do impact the API
>> >>> would
>> >>>>>> also need a specification update.
>> >>>>>>
>> >>>>>> Best regards,
>> >>>>>>
>> >>>>>> David
>> >>>>>>
>> >>>>>> [5] https://projects.eclipse.org/projects/technology.osgi/who
>> >>>>>>
>> >>>>>> On Thu, 6 May 2021 at 16:23, Jean-Baptiste Onofre <jb@nanthrax.net
>> >
>> >>>>> wrote:
>> >>>>>>
>> >>>>>>> Hi David,
>> >>>>>>>
>> >>>>>>> It makes sense and it would be more "consistent" to have a single
>> >>>>>>> repository.
>> >>>>>>>
>> >>>>>>> As Converter is part of the "spec", it makes sense to be located
>> at
>> >>>>>>> Eclipse.
>> >>>>>>>
>> >>>>>>> My only "concern" is about the contributions/contributors on Felix
>> >>>>>>> Converter.
>> >>>>>>> Will all Felix committers be able to change/maintain code at
>> Eclipse
>> >>>>> (the
>> >>>>>>> code coming from Felix Converter) ?
>> >>>>>>>
>> >>>>>>> Regards
>> >>>>>>> JB
>> >>>>>>>
>> >>>>>>>> Le 6 mai 2021 à 17:17, davidb@apache.org a écrit :
>> >>>>>>>>
>> >>>>>>>> Hi all,
>> >>>>>>>>
>> >>>>>>>> As most would have noticed, OSGi has moved to the Eclipse
>> Foundation
>> >>>>> [1]
>> >>>>>>>> and all the future OSGi specification work will happen there [2].
>> >>>>>>>>
>> >>>>>>>> The Converter that's in the Felix codebase is an implementation
>> of
>> >>>>> the
>> >>>>>>> OSGi
>> >>>>>>>> Converter specification [3]. As Converter is a 'util'
>> specification,
>> >>>>> OSGi
>> >>>>>>>> also provides an implementation with the API. There could be
>> other
>> >>>>>>>> implementations as well, this is similar to what is done with
>> Push
>> >>>>>>> Streams
>> >>>>>>>> and the Service Tracker.
>> >>>>>>>>
>> >>>>>>>> The initial implementation of the Converter Util at OSGi was
>> based
>> >>>>> on the
>> >>>>>>>> same codebase as the Converter at Felix. In effect it's a fork.
>> Over
>> >>>>> time
>> >>>>>>>> the two forks have started to diverge a little, mostly due to
>> >>>>> different
>> >>>>>>>> fixes being applied to both of them.
>> >>>>>>>>
>> >>>>>>>> Now that OSGi is an Eclipse project and all of the OSGi
>> technology
>> >>> at
>> >>>>>>>> Eclipse is developed as ordinary opensource projects with the
>> ASL2
>> >>>>>>> license
>> >>>>>>>> I think it would be good if we could collapse these 2 forks into
>> one
>> >>>>>>> again.
>> >>>>>>>> Because the Converter is the implementation shipped by OSGi as
>> part
>> >>>>> of
>> >>>>>>> its
>> >>>>>>>> spec API (into [4]), we can't really remove the implementation
>> from
>> >>>>> the
>> >>>>>>>> OSGi codebase.
>> >>>>>>>> So I would like to discuss removing the Converter from the Felix
>> >>>>>>> codebase,
>> >>>>>>>> so that the codebase can live on in a single location which would
>> >>> be:
>> >>>>>>>>
>> >>>>>>>
>> >>>>>
>> >>>
>> https://github.com/osgi/osgi/tree/main/org.osgi.util.converter/src/org/osgi/util/converter
>> >>>>>>>>
>> >>>>>>>> Obviously this would mean to consolidate all the bugfixes that
>> went
>> >>>>> into
>> >>>>>>>> its Felix codebase into the combined one.
>> >>>>>>>> Combining the codebases into one would mean that all users get
>> the
>> >>>>>>> benefit
>> >>>>>>>> from work done to the implementation by both communities.
>> >>>>>>>>
>> >>>>>>>> I hope that the Felix community would be open to this.
>> >>>>>>>>
>> >>>>>>>> Best regards,
>> >>>>>>>>
>> >>>>>>>> David Bosschaert
>> >>>>>>>>
>> >>>>>>>> [1]
>> >>>>>>>>
>> >>>>>>>
>> >>>>>
>> >>>
>> https://newsroom.eclipse.org/news/announcements/osgi-alliance-transfers-governance-osgi-specifications-open-source-software
>> >>>>>>>> [2] https://projects.eclipse.org/projects/technology.osgi
>> >>>>>>>> [3]
>> >>>>>>>
>> >>>>>
>> >>>
>> https://docs.osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html
>> >>>>>>>> [4]
>> >>> https://repo1.maven.org/maven2/org/osgi/org.osgi.util.converter/
>> >>>>>>>
>> >>>>>>>
>> >>>>>
>> >>>
>> >>>
>>
>>
Re: [Discuss] Moving the Converter implementation to OSGi at Eclipse
Posted by da...@apache.org.
Hi Konrad,
I'll look into that.
Cheers,
David
On Thu, 3 Jun 2021 at 10:17, Konrad Windszus <ko...@gmx.de> wrote:
> Hi David,
> thanks for doing the merge. Can you spin a release now? What is the
> release process at Eclipse?
> Regards,
> Konrad
>
> > On 3. Jun 2021, at 10:34, davidb@apache.org wrote:
> >
> > Hi all,
> >
> > The OSGi Converter has now moved to
> > https://github.com/osgi/osgi/tree/main/org.osgi.util.converter and
> patches
> > are most welcome :)
> >
> > I've removed the files from the Felix codebase
> >
> https://github.com/apache/felix-dev/commit/143ba444db23ca1746a8e28824025bb6b2327ca8
> > however they are still present in the project history, of course.
> >
> > Snapshots can be picked up from
> >
> https://oss.sonatype.org/content/repositories/snapshots/org/osgi/org.osgi.util.converter/
> >
> > Best regards,
> >
> > David
> >
> > On Thu, 27 May 2021 at 09:18, <da...@apache.org> wrote:
> >
> >> Hi all,
> >>
> >> Thanks for the discussion. I'll initiate the migration of the
> >> converter/converter codebase as discussed.
> >>
> >> Kind regards,
> >>
> >> David Bosschaert
> >>
> >> On Mon, 10 May 2021 at 23:49, David Leangen <os...@leangen.net> wrote:
> >>
> >>>
> >>> Hey David,
> >>>
> >>> Ok, thanks!
> >>>
> >>> =David
> >>>
> >>>
> >>>
> >>>> On May 10, 2021, at 21:25, David Bosschaert <
> david.bosschaert@gmail.com>
> >>> wrote:
> >>>>
> >>>> Hi David,
> >>>>
> >>>> Under the 'converter' umbrella in Felix there are 3 subprojects
> besides
> >>> the
> >>>> converter itself:
> >>>> * serializer
> >>>> * schematizer
> >>>> * persister
> >>>>
> >>>> I personally think it would be absolutely fine to leave them in Apache
> >>>> Felix. They build atop the converter. The converter API itself doesn't
> >>>> change in any way, so these components can just stay where they are...
> >>>>
> >>>> Does that make sense to you?
> >>>>
> >>>> Cheers,
> >>>>
> >>>> David
> >>>>
> >>>> On Mon, 10 May 2021 at 11:24, David Leangen (OSGi) <os...@leangen.net>
> >>> wrote:
> >>>>
> >>>>> Hey David,
> >>>>>
> >>>>> Thanks as always for all your great contributions.
> >>>>>
> >>>>> I was just wondering about the Serializer. Although I have not put
> any
> >>>>> work into for a while (including releasing, which I have not yet
> >>> managed to
> >>>>> get set up to do), I at least still use it, and I still think it is a
> >>>>> useful, even necessary tool. Unless you know of something else that
> >>> does
> >>>>> the job?
> >>>>>
> >>>>> Cheers,
> >>>>> =David
> >>>>>
> >>>>> What one programmer can do in one month, two programmers can do in
> two
> >>>>> months. (Fred Brooks)
> >>>>>
> >>>>> On May 7, 2021 18:18 +0900, davidb@apache.org, wrote:
> >>>>>> Hi JB,
> >>>>>>
> >>>>>> Some of the contributors of the Converter at Felix are already
> >>> committers
> >>>>>> at the Eclipse project [5].
> >>>>>> Others can just create PRs for any changes to the
> >>>>>> https://github.com/osgi/osgi/ project. As it's an opensource
> project
> >>> you
> >>>>>> can earn committer karma the usual open-source way.
> >>>>>> I have done a quick commit grep and found that of the 200 commits to
> >>> the
> >>>>>> converter there are 13 made by people who are not already committers
> >>> at
> >>>>> the
> >>>>>> OSGi project at Eclipse.
> >>>>>>
> >>>>>> I have also checked with Eclipse around releasing the component. Any
> >>>>> fixes
> >>>>>> that don't impact the API, i.e. micro-version releases can be done
> >>> from
> >>>>> an
> >>>>>> Eclipse project pretty much any time. Fixes that do impact the API
> >>> would
> >>>>>> also need a specification update.
> >>>>>>
> >>>>>> Best regards,
> >>>>>>
> >>>>>> David
> >>>>>>
> >>>>>> [5] https://projects.eclipse.org/projects/technology.osgi/who
> >>>>>>
> >>>>>> On Thu, 6 May 2021 at 16:23, Jean-Baptiste Onofre <jb...@nanthrax.net>
> >>>>> wrote:
> >>>>>>
> >>>>>>> Hi David,
> >>>>>>>
> >>>>>>> It makes sense and it would be more "consistent" to have a single
> >>>>>>> repository.
> >>>>>>>
> >>>>>>> As Converter is part of the "spec", it makes sense to be located at
> >>>>>>> Eclipse.
> >>>>>>>
> >>>>>>> My only "concern" is about the contributions/contributors on Felix
> >>>>>>> Converter.
> >>>>>>> Will all Felix committers be able to change/maintain code at
> Eclipse
> >>>>> (the
> >>>>>>> code coming from Felix Converter) ?
> >>>>>>>
> >>>>>>> Regards
> >>>>>>> JB
> >>>>>>>
> >>>>>>>> Le 6 mai 2021 à 17:17, davidb@apache.org a écrit :
> >>>>>>>>
> >>>>>>>> Hi all,
> >>>>>>>>
> >>>>>>>> As most would have noticed, OSGi has moved to the Eclipse
> Foundation
> >>>>> [1]
> >>>>>>>> and all the future OSGi specification work will happen there [2].
> >>>>>>>>
> >>>>>>>> The Converter that's in the Felix codebase is an implementation of
> >>>>> the
> >>>>>>> OSGi
> >>>>>>>> Converter specification [3]. As Converter is a 'util'
> specification,
> >>>>> OSGi
> >>>>>>>> also provides an implementation with the API. There could be other
> >>>>>>>> implementations as well, this is similar to what is done with Push
> >>>>>>> Streams
> >>>>>>>> and the Service Tracker.
> >>>>>>>>
> >>>>>>>> The initial implementation of the Converter Util at OSGi was based
> >>>>> on the
> >>>>>>>> same codebase as the Converter at Felix. In effect it's a fork.
> Over
> >>>>> time
> >>>>>>>> the two forks have started to diverge a little, mostly due to
> >>>>> different
> >>>>>>>> fixes being applied to both of them.
> >>>>>>>>
> >>>>>>>> Now that OSGi is an Eclipse project and all of the OSGi technology
> >>> at
> >>>>>>>> Eclipse is developed as ordinary opensource projects with the ASL2
> >>>>>>> license
> >>>>>>>> I think it would be good if we could collapse these 2 forks into
> one
> >>>>>>> again.
> >>>>>>>> Because the Converter is the implementation shipped by OSGi as
> part
> >>>>> of
> >>>>>>> its
> >>>>>>>> spec API (into [4]), we can't really remove the implementation
> from
> >>>>> the
> >>>>>>>> OSGi codebase.
> >>>>>>>> So I would like to discuss removing the Converter from the Felix
> >>>>>>> codebase,
> >>>>>>>> so that the codebase can live on in a single location which would
> >>> be:
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>
> https://github.com/osgi/osgi/tree/main/org.osgi.util.converter/src/org/osgi/util/converter
> >>>>>>>>
> >>>>>>>> Obviously this would mean to consolidate all the bugfixes that
> went
> >>>>> into
> >>>>>>>> its Felix codebase into the combined one.
> >>>>>>>> Combining the codebases into one would mean that all users get the
> >>>>>>> benefit
> >>>>>>>> from work done to the implementation by both communities.
> >>>>>>>>
> >>>>>>>> I hope that the Felix community would be open to this.
> >>>>>>>>
> >>>>>>>> Best regards,
> >>>>>>>>
> >>>>>>>> David Bosschaert
> >>>>>>>>
> >>>>>>>> [1]
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>
> https://newsroom.eclipse.org/news/announcements/osgi-alliance-transfers-governance-osgi-specifications-open-source-software
> >>>>>>>> [2] https://projects.eclipse.org/projects/technology.osgi
> >>>>>>>> [3]
> >>>>>>>
> >>>>>
> >>>
> https://docs.osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html
> >>>>>>>> [4]
> >>> https://repo1.maven.org/maven2/org/osgi/org.osgi.util.converter/
> >>>>>>>
> >>>>>>>
> >>>>>
> >>>
> >>>
>
>
Re: [Discuss] Moving the Converter implementation to OSGi at Eclipse
Posted by Konrad Windszus <ko...@gmx.de>.
Hi David,
thanks for doing the merge. Can you spin a release now? What is the release process at Eclipse?
Regards,
Konrad
> On 3. Jun 2021, at 10:34, davidb@apache.org wrote:
>
> Hi all,
>
> The OSGi Converter has now moved to
> https://github.com/osgi/osgi/tree/main/org.osgi.util.converter and patches
> are most welcome :)
>
> I've removed the files from the Felix codebase
> https://github.com/apache/felix-dev/commit/143ba444db23ca1746a8e28824025bb6b2327ca8
> however they are still present in the project history, of course.
>
> Snapshots can be picked up from
> https://oss.sonatype.org/content/repositories/snapshots/org/osgi/org.osgi.util.converter/
>
> Best regards,
>
> David
>
> On Thu, 27 May 2021 at 09:18, <da...@apache.org> wrote:
>
>> Hi all,
>>
>> Thanks for the discussion. I'll initiate the migration of the
>> converter/converter codebase as discussed.
>>
>> Kind regards,
>>
>> David Bosschaert
>>
>> On Mon, 10 May 2021 at 23:49, David Leangen <os...@leangen.net> wrote:
>>
>>>
>>> Hey David,
>>>
>>> Ok, thanks!
>>>
>>> =David
>>>
>>>
>>>
>>>> On May 10, 2021, at 21:25, David Bosschaert <da...@gmail.com>
>>> wrote:
>>>>
>>>> Hi David,
>>>>
>>>> Under the 'converter' umbrella in Felix there are 3 subprojects besides
>>> the
>>>> converter itself:
>>>> * serializer
>>>> * schematizer
>>>> * persister
>>>>
>>>> I personally think it would be absolutely fine to leave them in Apache
>>>> Felix. They build atop the converter. The converter API itself doesn't
>>>> change in any way, so these components can just stay where they are...
>>>>
>>>> Does that make sense to you?
>>>>
>>>> Cheers,
>>>>
>>>> David
>>>>
>>>> On Mon, 10 May 2021 at 11:24, David Leangen (OSGi) <os...@leangen.net>
>>> wrote:
>>>>
>>>>> Hey David,
>>>>>
>>>>> Thanks as always for all your great contributions.
>>>>>
>>>>> I was just wondering about the Serializer. Although I have not put any
>>>>> work into for a while (including releasing, which I have not yet
>>> managed to
>>>>> get set up to do), I at least still use it, and I still think it is a
>>>>> useful, even necessary tool. Unless you know of something else that
>>> does
>>>>> the job?
>>>>>
>>>>> Cheers,
>>>>> =David
>>>>>
>>>>> What one programmer can do in one month, two programmers can do in two
>>>>> months. (Fred Brooks)
>>>>>
>>>>> On May 7, 2021 18:18 +0900, davidb@apache.org, wrote:
>>>>>> Hi JB,
>>>>>>
>>>>>> Some of the contributors of the Converter at Felix are already
>>> committers
>>>>>> at the Eclipse project [5].
>>>>>> Others can just create PRs for any changes to the
>>>>>> https://github.com/osgi/osgi/ project. As it's an opensource project
>>> you
>>>>>> can earn committer karma the usual open-source way.
>>>>>> I have done a quick commit grep and found that of the 200 commits to
>>> the
>>>>>> converter there are 13 made by people who are not already committers
>>> at
>>>>> the
>>>>>> OSGi project at Eclipse.
>>>>>>
>>>>>> I have also checked with Eclipse around releasing the component. Any
>>>>> fixes
>>>>>> that don't impact the API, i.e. micro-version releases can be done
>>> from
>>>>> an
>>>>>> Eclipse project pretty much any time. Fixes that do impact the API
>>> would
>>>>>> also need a specification update.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> David
>>>>>>
>>>>>> [5] https://projects.eclipse.org/projects/technology.osgi/who
>>>>>>
>>>>>> On Thu, 6 May 2021 at 16:23, Jean-Baptiste Onofre <jb...@nanthrax.net>
>>>>> wrote:
>>>>>>
>>>>>>> Hi David,
>>>>>>>
>>>>>>> It makes sense and it would be more "consistent" to have a single
>>>>>>> repository.
>>>>>>>
>>>>>>> As Converter is part of the "spec", it makes sense to be located at
>>>>>>> Eclipse.
>>>>>>>
>>>>>>> My only "concern" is about the contributions/contributors on Felix
>>>>>>> Converter.
>>>>>>> Will all Felix committers be able to change/maintain code at Eclipse
>>>>> (the
>>>>>>> code coming from Felix Converter) ?
>>>>>>>
>>>>>>> Regards
>>>>>>> JB
>>>>>>>
>>>>>>>> Le 6 mai 2021 à 17:17, davidb@apache.org a écrit :
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> As most would have noticed, OSGi has moved to the Eclipse Foundation
>>>>> [1]
>>>>>>>> and all the future OSGi specification work will happen there [2].
>>>>>>>>
>>>>>>>> The Converter that's in the Felix codebase is an implementation of
>>>>> the
>>>>>>> OSGi
>>>>>>>> Converter specification [3]. As Converter is a 'util' specification,
>>>>> OSGi
>>>>>>>> also provides an implementation with the API. There could be other
>>>>>>>> implementations as well, this is similar to what is done with Push
>>>>>>> Streams
>>>>>>>> and the Service Tracker.
>>>>>>>>
>>>>>>>> The initial implementation of the Converter Util at OSGi was based
>>>>> on the
>>>>>>>> same codebase as the Converter at Felix. In effect it's a fork. Over
>>>>> time
>>>>>>>> the two forks have started to diverge a little, mostly due to
>>>>> different
>>>>>>>> fixes being applied to both of them.
>>>>>>>>
>>>>>>>> Now that OSGi is an Eclipse project and all of the OSGi technology
>>> at
>>>>>>>> Eclipse is developed as ordinary opensource projects with the ASL2
>>>>>>> license
>>>>>>>> I think it would be good if we could collapse these 2 forks into one
>>>>>>> again.
>>>>>>>> Because the Converter is the implementation shipped by OSGi as part
>>>>> of
>>>>>>> its
>>>>>>>> spec API (into [4]), we can't really remove the implementation from
>>>>> the
>>>>>>>> OSGi codebase.
>>>>>>>> So I would like to discuss removing the Converter from the Felix
>>>>>>> codebase,
>>>>>>>> so that the codebase can live on in a single location which would
>>> be:
>>>>>>>>
>>>>>>>
>>>>>
>>> https://github.com/osgi/osgi/tree/main/org.osgi.util.converter/src/org/osgi/util/converter
>>>>>>>>
>>>>>>>> Obviously this would mean to consolidate all the bugfixes that went
>>>>> into
>>>>>>>> its Felix codebase into the combined one.
>>>>>>>> Combining the codebases into one would mean that all users get the
>>>>>>> benefit
>>>>>>>> from work done to the implementation by both communities.
>>>>>>>>
>>>>>>>> I hope that the Felix community would be open to this.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>>
>>>>>>>> David Bosschaert
>>>>>>>>
>>>>>>>> [1]
>>>>>>>>
>>>>>>>
>>>>>
>>> https://newsroom.eclipse.org/news/announcements/osgi-alliance-transfers-governance-osgi-specifications-open-source-software
>>>>>>>> [2] https://projects.eclipse.org/projects/technology.osgi
>>>>>>>> [3]
>>>>>>>
>>>>>
>>> https://docs.osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html
>>>>>>>> [4]
>>> https://repo1.maven.org/maven2/org/osgi/org.osgi.util.converter/
>>>>>>>
>>>>>>>
>>>>>
>>>
>>>