[jira] [Commented] (HADOOP-12054) RPC client should not retry for InvalidToken exceptions

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569996#comment-14569996 ] 

Hadoop QA commented on HADOOP-12054:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  16m 21s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 30s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 41s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 21s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  4s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 2  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 49s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |  36m 51s | Tests failed in hadoop-common. |
| | |  75m 47s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.security.token.delegation.web.TestWebDelegationToken |
| Timed out tests | org.apache.hadoop.http.TestHttpCookieFlag |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737025/HADOOP-12054.01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 03fb5c6 |
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/whitespace.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/console |


This message was automatically generated.

> RPC client should not retry for InvalidToken exceptions
> -------------------------------------------------------
>
>                 Key: HADOOP-12054
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12054
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.4.0
>            Reporter: Daryn Sharp
>            Assignee: Varun Saxena
>            Priority: Critical
>         Attachments: HADOOP-12054.01.patch
>
>
> An InvalidToken exception is thrown for expired or cancelled tokens.  An InvalidToken not wrapped in a RetriableException must be considered fatal by the retry proxies or clients will spam the service with failed connections.  Depending on the context, a service may be degraded when spammed with thousands of connection failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)