[GitHub] [accumulo-examples] keith-turner commented on issue #45: reservations example fails

[GitBox <gi...@apache.org>]

keith-turner commented on issue #45: reservations example fails
URL: https://github.com/apache/accumulo-examples/issues/45#issuecomment-490566386
 
 
   > I took a look at this and it appears the reason why the client is closing is because the try-block around the client initialization closes right after connecting.
   
   I took a look, that does seem to be the problem.  Below is the code you mentioned.
   
   https://github.com/apache/accumulo-examples/blob/master/src/main/java/org/apache/accumulo/examples/reservations/ARS.java#L304
   
   >  Since this is an example, we could remove the try-block for the client connection
   
   That would be my choice.  Its an example, so do not want to do anything that makes it hard to follow. Could add a comment saying  `its good to close clients when possible, but it was not done here for simplicity`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services