You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by x461909066 <gi...@git.apache.org> on 2018/05/07 09:24:44 UTC

[GitHub] incubator-weex pull request #1155: [WEEX-340][iOS]Fix the window problem whe...

GitHub user x461909066 opened a pull request:

    https://github.com/apache/incubator-weex/pull/1155

    [WEEX-340][iOS]Fix the window problem where weex toast is displayed

    Because the APP's keyWindow usually change with the business, weex's toast view should be displayed in the window where weex is located. If the window does not exist, it should displayed on the weex root view.
    
    U can check this [EXAMPLE](http://dotwe.org/vue/3ce829a89653d651aeadf145af3f98a0)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/x461909066/incubator-weex bugFix/toast_window

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1155
    
----
commit b7277a08c776c6c6b8bd47d7ad52c87bb66c9f5d
Author: jinxiaotong <ji...@...>
Date:   2018-05-07T09:23:54Z

    [WEEX-340][iOS]Fix the window problem where weex toast is displayed
    
    Because the APP's keyWindow usually change with the business, weex's toast view should be displayed in the window where weex is located. If the window does not exist, it should displayed on the weex root view.
    
    U can check this [EXAMPLE](http://dotwe.org/vue/3ce829a89653d651aeadf145af3f98a0)

----


---

[GitHub] incubator-weex pull request #1155: [WEEX-340][iOS]Fix the window problem whe...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1155


---

[GitHub] incubator-weex issue #1155: [WEEX-340][iOS]Fix the window problem where weex...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1155
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---