You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/08 16:34:41 UTC
[GitHub] [dubbo] plusmancn opened a new pull request #8734: fix: the consumerModel's NPE in TripleClientHandler
plusmancn opened a new pull request #8734:
URL: https://github.com/apache/dubbo/pull/8734
Fixes #8733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a change in pull request #8734: FIX: the consumerModel's NPE in TripleClientHandler
Posted by GitBox <gi...@apache.org>.
EarthChen commented on a change in pull request #8734:
URL: https://github.com/apache/dubbo/pull/8734#discussion_r704901953
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientHandler.java
##########
@@ -75,7 +75,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
private void writeRequest(ChannelHandlerContext ctx, final Request req, final ChannelPromise promise) {
final RpcInvocation inv = (RpcInvocation) req.getData();
final URL url = inv.getInvoker().getUrl();
- ConsumerModel consumerModel = (ConsumerModel) url.getServiceModel();
+ ConsumerModel consumerModel = inv.getServiceModel() != null ? (ConsumerModel) inv.getServiceModel() : (ConsumerModel) url.getServiceModel();
Review comment:
If there were no errors in the previous logic, this would not be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao merged pull request #8734: FIX: the consumerModel's NPE in TripleClientHandler
Posted by GitBox <gi...@apache.org>.
guohao merged pull request #8734:
URL: https://github.com/apache/dubbo/pull/8734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org