[GitHub] [iceberg] rdblue commented on a diff in pull request #4881: Core: Add round-trip serialization to RESTCatalog tests

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4881:
URL: https://github.com/apache/iceberg/pull/4881#discussion_r883228811


##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -168,11 +168,24 @@ public static LoadTableResponse stageTableCreate(Catalog catalog, Namespace name
     properties.put("created-at", OffsetDateTime.now().toString());
     properties.putAll(request.properties());
 
+    String location;
+    if (request.location() != null) {
+      location = request.location();
+    } else {
+      location = catalog.buildTable(ident, request.schema())

Review Comment:
   A missing location returned by `stageCreate` was causing `TableMetadata` deserialization to fail. This delegates creating a table location to the wrapped catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org