You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Guy Allard (JIRA)" <ji...@apache.org> on 2012/10/13 17:16:03 UTC
[jira] [Created] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Guy Allard created AMQ-4104:
-------------------------------
Summary: STOMP 1.1 CONNECTED Frame has erroneously encoded headers
Key: AMQ-4104
URL: https://issues.apache.org/jira/browse/AMQ-4104
Project: ActiveMQ
Issue Type: Bug
Components: stomp
Affects Versions: 5.7.0
Environment: Ubuntu 11.10
Reporter: Guy Allard
The STOMP 1.1 specification says:
All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
AMQ 5.7.0 is out of specification with regard to this.
Example telnet session:
$ telnet tjjackson 61613
Trying 192.168.1.200...
Connected to tjjackson.
Escape character is '^]'.
CONNECT
login:me
passcode:asdasd
accept-version:1.1
host:tjjackson
heart-beat:10000,15000
^@
CONNECTED
heart-beat:15000,10000
session:ID\ctjjackson-55318-1350137693500-2\c1
server:ActiveMQ/5.7.0
version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reopened AMQ-4104:
-------------------------------
Assignee: Timothy Bish
> STOMP 1.1 CONNECTED Frame has erroneously encoded headers
> ---------------------------------------------------------
>
> Key: AMQ-4104
> URL: https://issues.apache.org/jira/browse/AMQ-4104
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.7.0
> Environment: Ubuntu 11.10
> Reporter: Guy Allard
> Assignee: Timothy Bish
>
> The STOMP 1.1 specification says:
> All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
> AMQ 5.7.0 is out of specification with regard to this.
> Example telnet session:
> $ telnet tjjackson 61613
> Trying 192.168.1.200...
> Connected to tjjackson.
> Escape character is '^]'.
> CONNECT
> login:me
> passcode:asdasd
> accept-version:1.1
> host:tjjackson
> heart-beat:10000,15000
> ^@
> CONNECTED
> heart-beat:15000,10000
> session:ID\ctjjackson-55318-1350137693500-2\c1
> server:ActiveMQ/5.7.0
> version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish closed AMQ-4104.
-----------------------------
Resolution: Cannot Reproduce
I tested this against the 5.7 release and this is not happening, the code doesn't encode headers until after the CONNECTED frame is sent and the protocol version is set. Reopen if you can provide a JUnit test case that reproduces this.
> STOMP 1.1 CONNECTED Frame has erroneously encoded headers
> ---------------------------------------------------------
>
> Key: AMQ-4104
> URL: https://issues.apache.org/jira/browse/AMQ-4104
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.7.0
> Environment: Ubuntu 11.10
> Reporter: Guy Allard
>
> The STOMP 1.1 specification says:
> All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
> AMQ 5.7.0 is out of specification with regard to this.
> Example telnet session:
> $ telnet tjjackson 61613
> Trying 192.168.1.200...
> Connected to tjjackson.
> Escape character is '^]'.
> CONNECT
> login:me
> passcode:asdasd
> accept-version:1.1
> host:tjjackson
> heart-beat:10000,15000
> ^@
> CONNECTED
> heart-beat:15000,10000
> session:ID\ctjjackson-55318-1350137693500-2\c1
> server:ActiveMQ/5.7.0
> version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Posted by "Guy Allard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476520#comment-13476520 ]
Guy Allard commented on AMQ-4104:
---------------------------------
Apologies, but my report of this was inaccurate and incomplete.
It only happens with: stomp+nio
> STOMP 1.1 CONNECTED Frame has erroneously encoded headers
> ---------------------------------------------------------
>
> Key: AMQ-4104
> URL: https://issues.apache.org/jira/browse/AMQ-4104
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.7.0
> Environment: Ubuntu 11.10
> Reporter: Guy Allard
>
> The STOMP 1.1 specification says:
> All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
> AMQ 5.7.0 is out of specification with regard to this.
> Example telnet session:
> $ telnet tjjackson 61613
> Trying 192.168.1.200...
> Connected to tjjackson.
> Escape character is '^]'.
> CONNECT
> login:me
> passcode:asdasd
> accept-version:1.1
> host:tjjackson
> heart-beat:10000,15000
> ^@
> CONNECTED
> heart-beat:15000,10000
> session:ID\ctjjackson-55318-1350137693500-2\c1
> server:ActiveMQ/5.7.0
> version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-4104.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.8.0
Fixed in trunk
> STOMP 1.1 CONNECTED Frame has erroneously encoded headers
> ---------------------------------------------------------
>
> Key: AMQ-4104
> URL: https://issues.apache.org/jira/browse/AMQ-4104
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.7.0
> Environment: Ubuntu 11.10
> Reporter: Guy Allard
> Assignee: Timothy Bish
> Fix For: 5.8.0
>
>
> The STOMP 1.1 specification says:
> All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
> AMQ 5.7.0 is out of specification with regard to this.
> Example telnet session:
> $ telnet tjjackson 61613
> Trying 192.168.1.200...
> Connected to tjjackson.
> Escape character is '^]'.
> CONNECT
> login:me
> passcode:asdasd
> accept-version:1.1
> host:tjjackson
> heart-beat:10000,15000
> ^@
> CONNECTED
> heart-beat:15000,10000
> session:ID\ctjjackson-55318-1350137693500-2\c1
> server:ActiveMQ/5.7.0
> version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4104) STOMP 1.1 CONNECTED Frame has
erroneously encoded headers
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477030#comment-13477030 ]
Timothy Bish commented on AMQ-4104:
-----------------------------------
Looks like the fix for AMQ-3823 is setting the Stomp version to eagerly in the NIO case which is the problem.
> STOMP 1.1 CONNECTED Frame has erroneously encoded headers
> ---------------------------------------------------------
>
> Key: AMQ-4104
> URL: https://issues.apache.org/jira/browse/AMQ-4104
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.7.0
> Environment: Ubuntu 11.10
> Reporter: Guy Allard
> Assignee: Timothy Bish
>
> The STOMP 1.1 specification says:
> All frames except the CONNECT and CONNECTED frames will also escape any colon or newline octets found in the resulting UTF-8 encoded headers. ...... The CONNECT and CONNECTED frames do not escape the colon or newline octets in order to remain backward compatible with STOMP 1.0.
> AMQ 5.7.0 is out of specification with regard to this.
> Example telnet session:
> $ telnet tjjackson 61613
> Trying 192.168.1.200...
> Connected to tjjackson.
> Escape character is '^]'.
> CONNECT
> login:me
> passcode:asdasd
> accept-version:1.1
> host:tjjackson
> heart-beat:10000,15000
> ^@
> CONNECTED
> heart-beat:15000,10000
> session:ID\ctjjackson-55318-1350137693500-2\c1
> server:ActiveMQ/5.7.0
> version:1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira