You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/06 08:53:12 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new issue, #23: Enable github status checks for CI
mdedetrich opened a new issue, #23:
URL: https://github.com/apache/incubator-pekko/issues/23
Currently its possible to merge a PR even if the status checks fail or even in the small span of time before they get triggered. Now that we have CI running properly, we should update the `Require status checks to pass before merging` under `Branch Protection Rules` for the main branch so that people cannot easily merge PR's if one of the status checks fail.
@pjfanning I am not sure if this is to be done directly under github actions or whether it needs to be organised with an INFRA ticket/`.asf.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on issue #23: Enable github status checks for CI
Posted by GitBox <gi...@apache.org>.
spangaer commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1304766692
Explicitly having to name the status checks for that feature to do anything meaningful, is an additional complication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich closed issue #23: Enable github status checks for CI
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #23: Enable github status checks for CI
URL: https://github.com/apache/incubator-pekko/issues/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #23: Enable github status checks for CI
Posted by GitBox <gi...@apache.org>.
pjfanning commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1304762548
This is something we will want to implement. I'm not yet sure that we have enough stability in the dev pipelines though.
In the end of the day, we are months away from any releases, anything that sneaks into the main branch can be fixed - this will hopefully be rare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #23: Enable github status checks for CI
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1304773976
> This is something we will want to implement. I'm not yet sure that we have enough stability in the dev pipelines though.
So we don't have to enable all of the status checks however there are ones that make sense to enable even now, i.e.
* `Scalafmt / Code is formatted (pull_request)`
* `Pull Requests / Check / Headers (pull_request)`
And all of the compile ones (I don't think we ever want to merge code that actually can't compile)
Also do note that even with status checks enabled you can bypass them, you just need to write permissions to the repo which in the current case is PMC members
> Explicitly having to name the status checks for that feature to do anything meaningful, is an additional complication.
I don't know what you mean, if you are talking about the logistics of enabling them then its really quite trivial, you get a dropdown of past checks that have triggered (which we are already at this point in time) and you just select the ones that you want to enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on issue #23: Enable github status checks for CI
Posted by GitBox <gi...@apache.org>.
spangaer commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1304795191
From UI it's not very complicated, from API there's a couple of pitfalls, which I assume will extrapolate to this asf.yml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on issue #23: Enable github status checks for CI
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1507270100
@mdedetrich is there anything left on this? Could it be closed now that it seems we have pipelines working and we have mandatory 1 reviewer to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #23: Enable github status checks for CI
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1507593429
I would say it's still currently being worked on (as in I am going through each pekko git report and putting the checks in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #23: Enable github status checks for CI
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1304869504
> From UI it's not very complicated, from API there's a couple of pitfalls, which I assume will extrapolate to this asf.yml file.
Ah thats what you mean, I assume if there is an example Apache project with a configuration it shouldn't be too hard to figure out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #23: Enable github status checks for CI
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #23:
URL: https://github.com/apache/incubator-pekko/issues/23#issuecomment-1559208319
This has already been done, closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org