You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/01/08 02:17:11 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1605: Fix the PR validate script so the auto label can be applied correctly.
jiajunwang opened a new pull request #1605:
URL: https://github.com/apache/helix/pull/1605
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1598
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Use the native github-script to finish the action.
### Tests
- [X] The following tests are written for this issue:
NA
Tested basic functions and script in my personal repo. But the eventual result need to be validated in the Apache repo.
- [X] The following is the result of the "mvn test" command on the appropriate module:
NA
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1605: Fix the PR validate script so the auto label can be applied correctly.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1605:
URL: https://github.com/apache/helix/pull/1605#issuecomment-758889264
Approved by @alirezazamani, I will merge it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1605: Fix the PR validate script so the auto label can be applied correctly.
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1605:
URL: https://github.com/apache/helix/pull/1605#discussion_r554797674
##########
File path: .github/workflows/Helix-PR-Premerge-Check.yml
##########
@@ -14,13 +14,62 @@ jobs:
runs-on: ubuntu-latest
steps:
- - name: Verify All Tasks are Finished
- uses: venkatsarvesh/pr-tasks-completed-action@v1.0.0
+ - name: Label PR if ready to be merged.
+ uses: actions/github-script@v3
with:
- repo-token: "${{ secrets.GITHUB_TOKEN }}"
- - name: Verify the PR has been approved
- uses: abinoda/label-when-approved-action@1.0.5
- env:
- APPROVALS: "1"
- ADD_LABEL: "CheckedAndApproved"
- GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+ github-token: ${{secrets.GITHUB_TOKEN}}
+ script: |
+ const approvalLabel = 'CheckedAndApproved'
Review comment:
"Label PR if ready to be merged" - there is an existing label "ready to merge", is it what you wanted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1605: Fix the PR validate script so the auto label can be applied correctly.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1605:
URL: https://github.com/apache/helix/pull/1605#discussion_r555319712
##########
File path: .github/workflows/Helix-PR-Premerge-Check.yml
##########
@@ -14,13 +14,62 @@ jobs:
runs-on: ubuntu-latest
steps:
- - name: Verify All Tasks are Finished
- uses: venkatsarvesh/pr-tasks-completed-action@v1.0.0
+ - name: Label PR if ready to be merged.
+ uses: actions/github-script@v3
with:
- repo-token: "${{ secrets.GITHUB_TOKEN }}"
- - name: Verify the PR has been approved
- uses: abinoda/label-when-approved-action@1.0.5
- env:
- APPROVALS: "1"
- ADD_LABEL: "CheckedAndApproved"
- GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+ github-token: ${{secrets.GITHUB_TOKEN}}
+ script: |
+ const approvalLabel = 'CheckedAndApproved'
Review comment:
No, what I want is to keep the same behavior as the original script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1605: Fix the PR validate script so the auto label can be applied correctly.
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1605:
URL: https://github.com/apache/helix/pull/1605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org