You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/25 05:01:33 UTC
[GitHub] [rocketmq] WJL3333 opened a new pull request #3374: [Optimize] Lazy init GetMessageResult only when find message.
WJL3333 opened a new pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374
2. adjust ArrayList initialCapacity in GetMessageResult to avoid object allocation
## What is the purpose of the change
Avoid unnecessary object allocation when getMessage.
GetMessageResult will create double ArrayList with 100 initialCapacity.
the pullBatchSize in consumer is 32 which means in default config. then 100 initialCapacity is unnecessary.
And when message not found. the allocation is also can be avoided.
## Brief changelog
1. lazy init GetMessageResult only when find message.
2. adjust ArrayList initialCapacity in GetMessageResult to avoid object allocation
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] WJL3333 removed a comment on pull request #3374: [ISSUE #3375] Lazy init GetMessageResult only when find message.
Posted by GitBox <gi...@apache.org>.
WJL3333 removed a comment on pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374#issuecomment-927012251
@RongtongJin @duhenglucky @odbozhou @maixiaohai please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] WJL3333 commented on pull request #3374: [#3375] Lazy init GetMessageResult only when find message.
Posted by GitBox <gi...@apache.org>.
WJL3333 commented on pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374#issuecomment-927012251
@RongtongJin @duhenglucky @odbozhou @maixiaohai please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #3374: [ISSUE #3375] Lazy init GetMessageResult only when find message.
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374#issuecomment-927264047
LGTM~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling merged pull request #3374: [ISSUE #3375] Lazy init GetMessageResult only when find message.
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org