[GitHub] [incubator-nuttx] patacongo commented on issue #78: Added a tool for listing the percentage of common lines in text files.

[GitBox <gi...@apache.org>]

patacongo commented on issue #78: Added a tool for listing the percentage of common lines in text files.
URL: https://github.com/apache/incubator-nuttx/pull/78#issuecomment-573320929
 
 
   I am going to close the PR without incorporating it.  I do not want to see a tool that encourages this bad way of thinking in the OS.  The imporant values are architecture modularly and clean interfaces.  This could potentially destroy both.
   
   There is no benefit to reducing code duplication.  Duplication is good.  It permits the modular architecture and it allows customizations.  Combining unrelated code for no reason other than it is similar is a terrible idea and cannot be considered.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services