[GitHub] [cassandra] blerer commented on a diff in pull request #2186: Improve memtable allocator accounting when updating AtomicBTreePartition

["blerer (via GitHub)" <gi...@apache.org>]

blerer commented on code in PR #2186:
URL: https://github.com/apache/cassandra/pull/2186#discussion_r1126661071


##########
src/java/org/apache/cassandra/db/rows/NativeCell.java:
##########
@@ -171,4 +171,16 @@ public long unsharedHeapSizeExcludingData()
         return EMPTY_SIZE;
     }
 
+    public long offHeapSize()
+    {
+        long size = simpleSize(MemoryUtil.getInt(peer + LENGTH));

Review Comment:
   Yes, it sounds much better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org