You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2018/05/15 20:09:43 UTC
[1/2] [text] Replace FindBugs with SpotBugs
Repository: commons-text
Updated Branches:
refs/heads/master 70151971b -> 01c1e1adf
Replace FindBugs with SpotBugs
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/0eac5c7d
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/0eac5c7d
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/0eac5c7d
Branch: refs/heads/master
Commit: 0eac5c7d1814251633503fa2e992f855247c8c8e
Parents: 7015197
Author: Pascal Schumacher <pa...@gmx.net>
Authored: Thu May 10 14:55:28 2018 +0200
Committer: Pascal Schumacher <pa...@gmx.net>
Committed: Tue May 15 22:07:47 2018 +0200
----------------------------------------------------------------------
fb-excludes.xml | 37 -------------------------------------
pom.xml | 22 +++++++++++-----------
sb-excludes.xml | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+), 48 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/0eac5c7d/fb-excludes.xml
----------------------------------------------------------------------
diff --git a/fb-excludes.xml b/fb-excludes.xml
deleted file mode 100644
index 44baec8..0000000
--- a/fb-excludes.xml
+++ /dev/null
@@ -1,37 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
- Licensed to the Apache Software Foundation (ASF) under one or more
- contributor license agreements. See the NOTICE file distributed with
- this work for additional information regarding copyright ownership.
- The ASF licenses this file to You under the Apache License, Version 2.0
- (the "License"); you may not use this file except in compliance with
- the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
--->
-<FindBugsFilter>
-
- <Match>
- <Class name="org.apache.commons.text.ExtendedMessageFormat" />
- <Bug code="UR" />
- </Match>
-
- <Match>
- <Class name="org.apache.commons.text.StrTokenizer" />
- <Method name="clone" />
- <Bug code="CN" />
- </Match>
-
- <Match>
- <Class name="org.apache.commons.text.StringTokenizer" />
- <Method name="clone" />
- <Bug code="CN" />
- </Match>
-
-</FindBugsFilter>
http://git-wip-us.apache.org/repos/asf/commons-text/blob/0eac5c7d/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index b077277..0135a78 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,6 +53,8 @@
<checkstyle.plugin.version>3.0.0</checkstyle.plugin.version>
<checkstyle.version>8.9</checkstyle.version>
+
+ <spotbugs.plugin.version>3.1.3.1</spotbugs.plugin.version>
</properties>
<dependencies>
@@ -89,7 +91,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
<pluginManagement>
<plugins>
<plugin>
@@ -137,12 +139,11 @@
</dependencies>
</plugin>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <!-- Use version from parent pom as that is adjusted according to the Java version used to run Maven -->
- <version>${commons.findbugs.version}</version>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs.plugin.version}</version>
<configuration>
- <excludeFilterFile>${basedir}/fb-excludes.xml</excludeFilterFile>
+ <excludeFilterFile>${basedir}/sb-excludes.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
@@ -209,12 +210,11 @@
</plugin>
<!-- Requires setting 'export MAVEN_OPTS="-Xmx512m" ' -->
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>findbugs-maven-plugin</artifactId>
- <!-- Use version from parent pom as that is adjusted according to the Java version used to run Maven -->
- <version>${commons.findbugs.version}</version>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs.plugin.version}</version>
<configuration>
- <excludeFilterFile>${basedir}/fb-excludes.xml</excludeFilterFile>
+ <excludeFilterFile>${basedir}/sb-excludes.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
http://git-wip-us.apache.org/repos/asf/commons-text/blob/0eac5c7d/sb-excludes.xml
----------------------------------------------------------------------
diff --git a/sb-excludes.xml b/sb-excludes.xml
new file mode 100644
index 0000000..44baec8
--- /dev/null
+++ b/sb-excludes.xml
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<FindBugsFilter>
+
+ <Match>
+ <Class name="org.apache.commons.text.ExtendedMessageFormat" />
+ <Bug code="UR" />
+ </Match>
+
+ <Match>
+ <Class name="org.apache.commons.text.StrTokenizer" />
+ <Method name="clone" />
+ <Bug code="CN" />
+ </Match>
+
+ <Match>
+ <Class name="org.apache.commons.text.StringTokenizer" />
+ <Method name="clone" />
+ <Bug code="CN" />
+ </Match>
+
+</FindBugsFilter>
[2/2] [text] Skip SpotBugs on Java 11,
because it uses ASM and ASM does not yet support the java 11 class
file format.
Posted by pa...@apache.org.
Skip SpotBugs on Java 11, because it uses ASM and ASM does not yet support the java 11 class file format.
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/01c1e1ad
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/01c1e1ad
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/01c1e1ad
Branch: refs/heads/master
Commit: 01c1e1adf80e8eb5de7d6096c0bdeb651f8f44df
Parents: 0eac5c7
Author: Pascal Schumacher <pa...@gmx.net>
Authored: Thu May 10 15:48:31 2018 +0200
Committer: Pascal Schumacher <pa...@gmx.net>
Committed: Tue May 15 22:07:48 2018 +0200
----------------------------------------------------------------------
pom.xml | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/01c1e1ad/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 0135a78..5cb4ca0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -430,6 +430,8 @@
<properties>
<!-- jacoco does not work with java 11 yet, see https://github.com/jacoco/jacoco/issues/663 -->
<jacoco.skip>true</jacoco.skip>
+ <!-- spotbugs does not work with java 11 yet, because ASM does not yet support the java 11 class file format -->
+ <spotbugs.skip>true</spotbugs.skip>
</properties>
</profile>
</profiles>