You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/04 02:48:43 UTC
[GitHub] clintropolis commented on a change in pull request #6898: Prohibit
assigning concurrent maps into Map-typed variables and fields and fix a
race condition in CoordinatorRuleManager
clintropolis commented on a change in pull request #6898: Prohibit assigning concurrent maps into Map-typed variables and fields and fix a race condition in CoordinatorRuleManager
URL: https://github.com/apache/incubator-druid/pull/6898#discussion_r253337505
##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -121,7 +121,7 @@
private final IndexIO indexIO;
private final IndexMerger indexMerger;
private final Cache cache;
- private final Map<SegmentIdWithShardSpec, Sink> sinks = new ConcurrentHashMap<>();
+ private final ConcurrentHashMap<SegmentIdWithShardSpec, Sink> sinks = new ConcurrentHashMap<>();
Review comment:
yeah, I guess this one looks like it could just be `ConcurrentMap`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org