You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/28 15:11:07 UTC
[GitHub] [spark] MaxGekk opened a new pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
MaxGekk opened a new pull request #30952:
URL: https://github.com/apache/spark/pull/30952
### What changes were proposed in this pull request?
For `InMemoryPartitionTable` used in tests, set empty partition metadata only when a partition doesn't exists.
### Why are the changes needed?
This bug fix is needed to use `INSERT INTO .. PARTITION` in other tests.
### Does this PR introduce _any_ user-facing change?
No. It affects only the v2 table catalog used in tests.
### How was this patch tested?
Added new UT to `DataSourceV2SQLSuite`, and run the affected test suite by:
```
$ build/sbt -Phive -Phive-thriftserver "test:testOnly org.apache.spark.sql.connector.DataSourceV2SQLSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751844778
**[Test build #133454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133454/testReport)** for PR 30952 at commit [`7c1861f`](https://github.com/apache/spark/commit/7c1861fc35142515f77edaf1d58c1bc90bc9c791).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751745940
**[Test build #133454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133454/testReport)** for PR 30952 at commit [`7c1861f`](https://github.com/apache/spark/commit/7c1861fc35142515f77edaf1d58c1bc90bc9c791).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751785967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38043/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751969553
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751845676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133454/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751963841
@cloud-fan @HyukjinKwon Please, review this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751845676
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133454/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751745940
**[Test build #133454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133454/testReport)** for PR 30952 at commit [`7c1861f`](https://github.com/apache/spark/commit/7c1861fc35142515f77edaf1d58c1bc90bc9c791).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30952:
URL: https://github.com/apache/spark/pull/30952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30952: [SPARK-33924][SQL][TESTS] Preserve partition metadata by INSERT INTO in v2 table catalog
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30952:
URL: https://github.com/apache/spark/pull/30952#issuecomment-751785967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38043/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org