[jira] [Commented] (SQOOP-1621) Sqoop2: Allow null as a dummy Schema

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209102#comment-14209102 ] 

Sqoop QA bot commented on SQOOP-1621:
-------------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12681207/SQOOP-1621.patch against branch sqoop2.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
{code}error: patch failed: common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java:17
error: common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java: patch does not apply
error: patch failed: common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java:36
error: common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java: patch does not apply
<stdin>:448: new blank line at EOF.
+
{code}

{color:green}SUCCESS:{color} Clean was successful

Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/595/console

This message is automatically generated.

> Sqoop2: Allow null as a dummy Schema
> ------------------------------------
>
>                 Key: SQOOP-1621
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1621
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Qian Xu
>            Assignee: Veena Basavaraj
>            Priority: Minor
>              Labels: newbie++
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1621.patch, SQOOP-1621.patch
>
>
> The {{getSchema}} of a {{Initializer}} cannot return {{null}} as a dummy schema instance, It is not necessary. Caller (i.e. {{Matcher}}) should check schema by using {{schema == null || schema.isEmpty()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)