[GitHub] [pulsar] Technoboy- commented on a change in pull request #14269: Fix validateGlobalNamespaceOwnership wrap exception issue.

[GitBox <gi...@apache.org>]

Technoboy- commented on a change in pull request #14269:
URL: https://github.com/apache/pulsar/pull/14269#discussion_r806461113



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -796,9 +796,9 @@ protected void validateGlobalNamespaceOwnership(NamespaceName namespace) {
                     validationFuture.complete(null);
                 }
             } else {
-                String msg = String.format("Policies not found for %s namespace", namespace.toString());
+                String msg = String.format("Namespace %s not found", namespace.toString());
                 log.warn(msg);
-                validationFuture.completeExceptionally(new RestException(Status.NOT_FOUND, msg));
+                validationFuture.completeExceptionally(new RestException(Status.NOT_FOUND, "Namespace not found"));

Review comment:
       Not looks great. Because policies mean namespace. If there is a namespace, there are policies. For user, it's about `namespace` here. 
   And some logs in Namespaces methods are also the same, not `policies` but `namespace`. Please help confirm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org