You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2018/11/30 23:04:04 UTC

[GitHub] Izakey commented on issue #10: Document Portfolio service API in component-test module

Izakey commented on issue #10: Document Portfolio service API in component-test module
URL: https://github.com/apache/fineract-cn-portfolio/pull/10#issuecomment-443366343
 
 
   Hey @pembemiriam 
   
   There was no need to close PR #9 as you just needed to update it with a commit.
   
   Aside from that, you need to do the following ;
   
   1. Fix this [error](https://pastebin.com/aCz0rG5C) by documenting the parts of the payload which you haven't yet done in PatternApiDocumentation.java 
   2. License your code by running ./gradlew licenseFormat 
   3. Read through @awasum 's review of [Customer-PR7](https://github.com/apache/fineract-cn-customer/pull/7/) to adjust the coding style by editing the projet's settings in IntelliJ IDEA as you can see [here](https://user-images.githubusercontent.com/15528032/44985452-59a93d80-af78-11e8-85eb-a5271cb9354c.png).
   4. Commit your changes and push to your [fineract-cn-portfolio](https://github.com/pembemiriam/fineract-cn-portfolio) .There's no need to create a new PR!
   
   Courage with the work !
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services