[GitHub] janpio commented on a change in pull request #656: Quick fix to support ANDROID_SDK_ROOT

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #656: Quick fix to support ANDROID_SDK_ROOT
URL: https://github.com/apache/cordova-android/pull/656#discussion_r255698123
 
 

 ##########
 File path: bin/templates/cordova/lib/check_reqs.js
 ##########
 @@ -356,12 +364,13 @@ module.exports.check_android_target = function (originalError) {
 module.exports.run = function () {
     return Q.all([this.check_java(), this.check_android()]).then(function (values) {
         console.log('Checking Java JDK and Android SDK versions');
-        console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
+        console.log('ANDROID_SDK_ROOT=' + process.env['ANDROID_SDK_ROOT'] + ' (recommended setting)');
+        console.log('ANDROID_HOME=' + process.env['ANDROID_HOME'] + '- DEPRECATED');
 
         if (!String(values[0]).startsWith('1.8.')) {
             throw new CordovaError(
                 'Requirements check failed for JDK 8 (\'1.8.*\')! Detected version: ' + values[0] + '\n' +
-                'Check your JAVA_HOME / ANDROID_HOME / PATH environment variables.'
+                'Check your ANDROID_SDK_ROOT / JAVA_HOME / PATH environment variables.'
 
 Review comment:
   ah, then I misread the meaning.
   
   ```suggestion
                   'Check your `ANDROID_SDK_ROOT`, `JAVA_HOME` and `PATH` environment variables.'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org