You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ja...@apache.org on 2022/10/09 08:32:19 UTC

[doris] branch master updated: [fix](Nereids) plan broadcast on right semi join by mistake (#13206)

This is an automated email from the ASF dual-hosted git repository.

jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new da933ecd21 [fix](Nereids) plan broadcast on right semi join by mistake (#13206)
da933ecd21 is described below

commit da933ecd2109fdd1fe3c8faf64ba0bf807d21e2a
Author: morrySnow <10...@users.noreply.github.com>
AuthorDate: Sun Oct 9 16:32:12 2022 +0800

    [fix](Nereids) plan broadcast on right semi join by mistake (#13206)
---
 .../src/main/java/org/apache/doris/nereids/trees/plans/JoinType.java  | 4 ++--
 fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/JoinType.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/JoinType.java
index 369636573d..764eecd154 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/JoinType.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/JoinType.java
@@ -92,8 +92,8 @@ public enum JoinType {
         return this == INNER_JOIN;
     }
 
-    public final boolean isReturnUnmatchedRightJoin() {
-        return this == RIGHT_OUTER_JOIN || this == RIGHT_ANTI_JOIN || this == FULL_OUTER_JOIN;
+    public final boolean isRightJoin() {
+        return this == RIGHT_OUTER_JOIN || this == RIGHT_ANTI_JOIN || this == RIGHT_SEMI_JOIN;
     }
 
     public final boolean isFullOuterJoin() {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java
index 23fdcdbca1..b65843d457 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java
@@ -57,7 +57,7 @@ public class JoinUtils {
     }
 
     public static boolean couldBroadcast(Join join) {
-        return !(join.getJoinType().isReturnUnmatchedRightJoin());
+        return !(join.getJoinType().isRightJoin() || join.getJoinType().isFullOuterJoin());
     }
 
     private static final class JoinSlotCoverageChecker {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org