You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by al...@apache.org on 2015/05/15 08:51:31 UTC

svn commit: r1679503 - /jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java

Author: alexparvulescu
Date: Fri May 15 06:51:31 2015
New Revision: 1679503

URL: http://svn.apache.org/r1679503
Log:
OAK-2872 ExternalLoginModule should clear state when login was not successful

Modified:
    jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java

Modified: jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java?rev=1679503&r1=1679502&r2=1679503&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java Fri May 15 06:51:31 2015
@@ -260,6 +260,8 @@ public class ExternalLoginModule extends
     @Override
     public boolean commit() throws LoginException {
         if (externalUser == null) {
+            // login attempt in this login module was not successful
+            clearState();
             return false;
         }
         Set<? extends Principal> principals = getPrincipals(externalUser.getId());